Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 25745003: Threads can race to be the first one to calculate the empty path ref's bounds. (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Threads can race to be the first one to calculate the empty path ref's bounds. To dodge the problem, call computeBounds when creating the global empty path ref. There's still another race here, which is that we can race to create the empty path ref in the first place. As written we can conceivably allocate an arbitrary number of empty path refs, one of which ends up pointed to by the global variable at the end. I've punted on fixing this for now because 1) tsan has not complained yet; 2) I think it can be fixed by the same approach as we can fix the memsets in 25415003, so I want to wait to see how that review goes first. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M include/core/SkPathRef.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
7 years, 2 months ago (2013-10-02 15:53:59 UTC) #1
mtklein
7 years, 2 months ago (2013-10-02 15:53:59 UTC) #2
robertphillips
I know I'm not powerful enough but lgtm
7 years, 2 months ago (2013-10-02 16:11:54 UTC) #3
bsalomon
On 2013/10/02 16:11:54, robertphillips wrote: > I know I'm not powerful enough but lgtm lgtm
7 years, 2 months ago (2013-10-02 16:25:38 UTC) #4
reed1
lgtm
7 years, 2 months ago (2013-10-02 16:30:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/25745003/1
7 years, 2 months ago (2013-10-02 16:31:40 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 16:42:59 UTC) #7
Message was sent while issue was closed.
Change committed as 11576

Powered by Google App Engine
This is Rietveld 408576698