include/core/SkPathRef.h - Issue 25745003: Threads can race to be the first one to calculate the empty path ref's bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkPathRef.h

Issue 25745003: Threads can race to be the first one to calculate the empty path ref's bounds. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/core/SkPathRef.h

diff --git a/include/core/SkPathRef.h b/include/core/SkPathRef.h

index 2c5086aa9211b33ebc3aff9a2df8b54a4118669a..e0758a47668b3269566bcd2319485bbf0d57f479 100644

--- a/include/core/SkPathRef.h

+++ b/include/core/SkPathRef.h

@@ -112,6 +112,7 @@ public:

static SkPathRef* gEmptyPathRef;

if (!gEmptyPathRef) {

gEmptyPathRef = SkNEW(SkPathRef); // leak!

+ gEmptyPathRef->computeBounds(); // Premptively avoid a race to clear fBoundsIsDirty.

}

return SkRef(gEmptyPathRef);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »