Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2574443003: [DevTools] Make line highlight stay in readonly editor. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make line highlight stay in readonly editor. With no cursor in readonly editor, highlight disappears very fast and it's impossible to say where it was. BUG=670417 Committed: https://crrev.com/f6b3c2daf84f02f4c39bae6c42460c6d8d1fe8c5 Cr-Commit-Position: refs/heads/master@{#437938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 4 chunks +14 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dgozman
Could you please take a look?
4 years ago (2016-12-12 19:18:17 UTC) #2
lushnikov
lgtm you could probably attribute this CL with crbug.com/670417
4 years ago (2016-12-12 19:58:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574443003/1
4 years ago (2016-12-12 20:38:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 22:43:50 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 22:45:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6b3c2daf84f02f4c39bae6c42460c6d8d1fe8c5
Cr-Commit-Position: refs/heads/master@{#437938}

Powered by Google App Engine
This is Rietveld 408576698