|
|
Chromium Code Reviews
DescriptionMake base/numerics abs match runtime libraries
This is the version all the runtime libraries seem to
use. So, I'm matching it on the assumption the
compiler may do something smarter if appropriate.
TBR=scottmg
NOTRY=true
Committed: https://crrev.com/e2d3dd950af5a6ee5f5a65a05f316c894b97fcf2
Cr-Commit-Position: refs/heads/master@{#437996}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
Description was changed from ========== Make base/numerics abs match runtime libraries This is the version all the runtime libraries seem to use. So, I'm matching it on the assumption the compiler may do something smarter if appropriate. BUG= ========== to ========== Make base/numerics abs match runtime libraries This is the version all the runtime libraries seem to use. So, I'm matching it on the assumption the compiler may do something smarter if appropriate. TBR=scottmg ==========
jschuh@chromium.org changed reviewers: + scottmg@chromium.org
Hey, since we already talked about this I assume a TBR is fine. I looked around, and every runtime library I could find used this pattern. So, it seems like I should just follow that.
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Make base/numerics abs match runtime libraries This is the version all the runtime libraries seem to use. So, I'm matching it on the assumption the compiler may do something smarter if appropriate. TBR=scottmg ========== to ========== Make base/numerics abs match runtime libraries This is the version all the runtime libraries seem to use. So, I'm matching it on the assumption the compiler may do something smarter if appropriate. TBR=scottmg NOTRY=true ==========
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481596474776230, "parent_rev":
"352dc798bdfe128ed73662e3e8423dad1f82e0c0", "commit_rev":
"e228f128461cee9e7417270082d770a08fc64514"}
Message was sent while issue was closed.
Description was changed from ========== Make base/numerics abs match runtime libraries This is the version all the runtime libraries seem to use. So, I'm matching it on the assumption the compiler may do something smarter if appropriate. TBR=scottmg NOTRY=true ========== to ========== Make base/numerics abs match runtime libraries This is the version all the runtime libraries seem to use. So, I'm matching it on the assumption the compiler may do something smarter if appropriate. TBR=scottmg NOTRY=true Review-Url: https://codereview.chromium.org/2574443002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Make base/numerics abs match runtime libraries This is the version all the runtime libraries seem to use. So, I'm matching it on the assumption the compiler may do something smarter if appropriate. TBR=scottmg NOTRY=true Review-Url: https://codereview.chromium.org/2574443002 ========== to ========== Make base/numerics abs match runtime libraries This is the version all the runtime libraries seem to use. So, I'm matching it on the assumption the compiler may do something smarter if appropriate. TBR=scottmg NOTRY=true Committed: https://crrev.com/e2d3dd950af5a6ee5f5a65a05f316c894b97fcf2 Cr-Commit-Position: refs/heads/master@{#437996} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e2d3dd950af5a6ee5f5a65a05f316c894b97fcf2 Cr-Commit-Position: refs/heads/master@{#437996} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
