Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2574443002: Make base/numerics abs match runtime libraries (Closed)

Created:
4 years ago by jschuh
Modified:
4 years ago
Reviewers:
scottmg
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make base/numerics abs match runtime libraries This is the version all the runtime libraries seem to use. So, I'm matching it on the assumption the compiler may do something smarter if appropriate. TBR=scottmg NOTRY=true Committed: https://crrev.com/e2d3dd950af5a6ee5f5a65a05f316c894b97fcf2 Cr-Commit-Position: refs/heads/master@{#437996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/numerics/safe_conversions_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
jschuh
Hey, since we already talked about this I assume a TBR is fine. I looked ...
4 years ago (2016-12-12 16:30:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574443002/1
4 years ago (2016-12-12 16:32:20 UTC) #5
scottmg
lgtm
4 years ago (2016-12-12 16:54:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/277943)
4 years ago (2016-12-13 02:05:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574443002/1
4 years ago (2016-12-13 02:35:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 02:41:51 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-13 02:46:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2d3dd950af5a6ee5f5a65a05f316c894b97fcf2
Cr-Commit-Position: refs/heads/master@{#437996}

Powered by Google App Engine
This is Rietveld 408576698