Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2574403002: Add a TaskPriority cap to the SWP redirection to experiment with no redirections at USER_BLOCKING. (Closed)

Created:
4 years ago by gab
Modified:
4 years ago
Reviewers:
fdoray, dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org, robliao
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a TaskPriority cap to the SWP redirection to experiment with no redirections at USER_BLOCKING. BUG=622400 Committed: https://crrev.com/2f05a7bb5e11f4e4a76c5f6532894189fb39ea9d Cr-Commit-Position: refs/heads/master@{#438966}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M base/threading/sequenced_worker_pool.h View 1 chunk +4 lines, -2 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 3 chunks +9 lines, -2 lines 1 comment Download
M components/task_scheduler_util/variations/browser_variations_util.cc View 1 chunk +14 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
gab
Francois PTAL, I'll land Finch CL today given upcoming freeze.
4 years ago (2016-12-15 21:07:36 UTC) #5
gab
+dcheng for R-S on base/threading's TaskScheduler redirection API tweaks
4 years ago (2016-12-15 21:19:43 UTC) #8
dcheng
//base lgtm https://codereview.chromium.org/2574403002/diff/20001/base/threading/sequenced_worker_pool.cc File base/threading/sequenced_worker_pool.cc (right): https://codereview.chromium.org/2574403002/diff/20001/base/threading/sequenced_worker_pool.cc#newcode650 base/threading/sequenced_worker_pool.cc:650: static_cast<int>(g_max_task_priority) Yay, C++.
4 years ago (2016-12-15 21:20:49 UTC) #9
fdoray
lgtm
4 years ago (2016-12-15 21:22:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574403002/20001
4 years ago (2016-12-15 22:18:08 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-16 00:28:02 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-16 00:30:28 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f05a7bb5e11f4e4a76c5f6532894189fb39ea9d
Cr-Commit-Position: refs/heads/master@{#438966}

Powered by Google App Engine
This is Rietveld 408576698