Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2063)

Issue 2574363002: Revert of Scheduler refactoring to virtually elimate redundant DoWorks (Closed)

Created:
4 years ago by gab
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org, altimin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset #9 id:160001 of https://codereview.chromium.org/2546423002/ ) Reason for revert: TSAN lock-order-inversion: http://crbug.com/674238 Original issue's description: > Scheduler refactoring to virtually elimate redundant DoWorks > > Note this patch, while useful in it's own right, needs base messageloop > cancellation support for full effect. Until that patch lands there may be > some pointless wakeups for canceled DoWorks. This is of particular concern > for using the scheduler on the compositor thread. > > BUG=578176 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c > Cr-Commit-Position: refs/heads/master@{#438173} TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=578176, 674238 NOPRESUBMIT=true Committed: https://crrev.com/9442d5557bc3a88b4864462ee14c7e65b5d93d1d Cr-Commit-Position: refs/heads/master@{#438659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -816 lines) Patch
M cc/test/ordered_simple_task_runner.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/ordered_simple_task_runner.cc View 4 chunks +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/scheduler/base/moveable_auto_lock.h View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h View 3 chunks +9 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc View 7 chunks +38 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h View 9 chunks +18 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc View 11 chunks +90 lines, -237 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc View 3 chunks +1 line, -250 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.h View 5 chunks +24 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.cc View 5 chunks +70 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc View 5 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.cc View 3 chunks +3 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
gab
Created Revert of Scheduler refactoring to virtually elimate redundant DoWorks
4 years ago (2016-12-14 19:34:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574363002/1
4 years ago (2016-12-14 19:35:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/326096)
4 years ago (2016-12-14 19:45:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574363002/1
4 years ago (2016-12-14 19:47:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 23:04:54 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9442d5557bc3a88b4864462ee14c7e65b5d93d1d Cr-Commit-Position: refs/heads/master@{#438659}
4 years ago (2016-12-14 23:06:44 UTC) #14
haraken
4 years ago (2016-12-14 23:52:39 UTC) #15
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698