Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset #9 id:160001 of https://codereview.chromium.org/2546423002/ )
Reason for revert:
TSAN lock-order-inversion: http://crbug.com/674238
Original issue's description:
> Scheduler refactoring to virtually elimate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect. Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> BUG=578176
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Cr-Commit-Position: refs/heads/master@{#438173}
TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176, 674238
NOPRESUBMIT=true
Committed: https://crrev.com/9442d5557bc3a88b4864462ee14c7e65b5d93d1d
Cr-Commit-Position: refs/heads/master@{#438659}
Description was changed from
==========
Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset
#9 id:160001 of https://codereview.chromium.org/2546423002/ )
Reason for revert:
TSAN lock-order-inversion: http://crbug.com/674238
Original issue's description:
> Scheduler refactoring to virtually elimate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect. Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> BUG=578176
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Cr-Commit-Position: refs/heads/master@{#438173}
TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176
==========
to
==========
Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset
#9 id:160001 of https://codereview.chromium.org/2546423002/ )
Reason for revert:
TSAN lock-order-inversion: http://crbug.com/674238
Original issue's description:
> Scheduler refactoring to virtually elimate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect. Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> BUG=578176
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Cr-Commit-Position: refs/heads/master@{#438173}
TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176, 674238
==========
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/326096)
Description was changed from
==========
Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset
#9 id:160001 of https://codereview.chromium.org/2546423002/ )
Reason for revert:
TSAN lock-order-inversion: http://crbug.com/674238
Original issue's description:
> Scheduler refactoring to virtually elimate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect. Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> BUG=578176
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Cr-Commit-Position: refs/heads/master@{#438173}
TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176, 674238
==========
to
==========
Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset
#9 id:160001 of https://codereview.chromium.org/2546423002/ )
Reason for revert:
TSAN lock-order-inversion: http://crbug.com/674238
Original issue's description:
> Scheduler refactoring to virtually elimate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect. Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> BUG=578176
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Cr-Commit-Position: refs/heads/master@{#438173}
TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176, 674238
NOPRESUBMIT=true
==========
Description was changed from
==========
Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset
#9 id:160001 of https://codereview.chromium.org/2546423002/ )
Reason for revert:
TSAN lock-order-inversion: http://crbug.com/674238
Original issue's description:
> Scheduler refactoring to virtually elimate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect. Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> BUG=578176
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Cr-Commit-Position: refs/heads/master@{#438173}
TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176, 674238
NOPRESUBMIT=true
==========
to
==========
Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset
#9 id:160001 of https://codereview.chromium.org/2546423002/ )
Reason for revert:
TSAN lock-order-inversion: http://crbug.com/674238
Original issue's description:
> Scheduler refactoring to virtually elimate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect. Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> BUG=578176
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Cr-Commit-Position: refs/heads/master@{#438173}
TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176, 674238
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2574363002
==========
Description was changed from
==========
Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset
#9 id:160001 of https://codereview.chromium.org/2546423002/ )
Reason for revert:
TSAN lock-order-inversion: http://crbug.com/674238
Original issue's description:
> Scheduler refactoring to virtually elimate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect. Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> BUG=578176
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Cr-Commit-Position: refs/heads/master@{#438173}
TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176, 674238
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2574363002
==========
to
==========
Revert of Scheduler refactoring to virtually elimate redundant DoWorks (patchset
#9 id:160001 of https://codereview.chromium.org/2546423002/ )
Reason for revert:
TSAN lock-order-inversion: http://crbug.com/674238
Original issue's description:
> Scheduler refactoring to virtually elimate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect. Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> BUG=578176
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Cr-Commit-Position: refs/heads/master@{#438173}
TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176, 674238
NOPRESUBMIT=true
Committed: https://crrev.com/9442d5557bc3a88b4864462ee14c7e65b5d93d1d
Cr-Commit-Position: refs/heads/master@{#438659}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9442d5557bc3a88b4864462ee14c7e65b5d93d1d Cr-Commit-Position: refs/heads/master@{#438659}
Issue 2574363002: Revert of Scheduler refactoring to virtually elimate redundant DoWorks
(Closed)
Created 4 years ago by gab
Modified 4 years ago
Reviewers: Sami, haraken, alex clarke (OOO till 29th)
Base URL:
Comments: 0