Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2574353002: [turbofan] Added --csa-trap-on-node option that helps debugging graph verification issues. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Added --csa-trap-on-node option that helps debugging graph verification issues. The error reported by the graph verifier looks like: # # Fatal error in ../src/compiler/machine-graph-verifier.cc, line 638 # TypeError: node #54:ChangeInt32ToInt64 uses node #53:ChangeUint32ToUint64 which doesn't have an int32-compatible representation. # # Specify option --csa-trap-on-node=test,54 for debugging. # BUG= Review-Url: https://codereview.chromium.org/2574353002 Cr-Commit-Position: refs/heads/master@{#41721} Committed: https://chromium.googlesource.com/v8/v8/+/1805315470418fe869801e891b7e51d791459c49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -17 lines) Patch
M src/code-stub-assembler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/compiler/machine-graph-verifier.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/machine-graph-verifier.cc View 13 chunks +27 lines, -4 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-14 19:28:36 UTC) #5
epertoso
lgtm
4 years ago (2016-12-15 13:30:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574353002/1
4 years ago (2016-12-15 13:30:59 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-15 13:32:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1805315470418fe869801e891b7e51d7914...

Powered by Google App Engine
This is Rietveld 408576698