Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2574313002: Clean up threading around VR Scene updates. (Closed)

Created:
4 years ago by mthiesse
Modified:
4 years ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, cjgrant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up threading around VR Scene updates. BUG=671302 Committed: https://crrev.com/ae6174ec3aa5ef0db0b68a40bb087e5ab8243b81 Cr-Commit-Position: refs/heads/master@{#438843}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -42 lines) Patch
M chrome/browser/android/vr_shell/ui_scene.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 1 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 1 2 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
mthiesse
PTAL
4 years ago (2016-12-14 18:35:28 UTC) #2
bshe
lgtm with nit https://codereview.chromium.org/2574313002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2574313002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc#newcode336 chrome/browser/android/vr_shell/vr_shell.cc:336: thread->WaitUntilThreadStarted(); you can probably use the ...
4 years ago (2016-12-14 22:05:13 UTC) #3
mthiesse
https://codereview.chromium.org/2574313002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2574313002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc#newcode336 chrome/browser/android/vr_shell/vr_shell.cc:336: thread->WaitUntilThreadStarted(); On 2016/12/14 22:05:13, bshe wrote: > you can ...
4 years ago (2016-12-14 22:39:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574313002/1
4 years ago (2016-12-14 22:40:11 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/android/vr_shell/vr_shell.cc: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-14 23:24:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574313002/20001
4 years ago (2016-12-15 15:21:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 16:18:25 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-15 16:21:48 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae6174ec3aa5ef0db0b68a40bb087e5ab8243b81
Cr-Commit-Position: refs/heads/master@{#438843}

Powered by Google App Engine
This is Rietveld 408576698