Clean up threading around VR Scene updates.

Clean up threading around VR Scene updates.

BUG=671302
Committed: https://crrev.com/ae6174ec3aa5ef0db0b68a40bb087e5ab8243b81
Cr-Commit-Position: refs/heads/master@{#438843}

[mthiesse, 2016-12-14 18:35:28]

mthiesse@chromium.org changed reviewers:
+ bshe@chromium.org

[mthiesse, 2016-12-14 18:35:28]

PTAL

[bshe, 2016-12-14 22:05:13]

lgtm with nit

https://codereview.chromium.org/2574313002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2574313002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:336:
thread->WaitUntilThreadStarted();
you can probably use the new function that you create in your previous CL.

[mthiesse, 2016-12-14 22:39:32]

https://codereview.chromium.org/2574313002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2574313002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:336:
thread->WaitUntilThreadStarted();
On 2016/12/14 22:05:13, bshe wrote:
> you can probably use the new function that you create in your previous CL. 

This one will probably land first. I'll do this when I rebase whichever one
lands second.

[mthiesse, 2016-12-14 22:39:44]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2016-12-14 22:40:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 23:24:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 23:24:26]

Failed to apply patch for chrome/browser/android/vr_shell/vr_shell.cc:
While running git apply --index -p1;
  error: patch failed: chrome/browser/android/vr_shell/vr_shell.cc:324
  error: chrome/browser/android/vr_shell/vr_shell.cc: patch does not apply

Patch:       chrome/browser/android/vr_shell/vr_shell.cc
Index: chrome/browser/android/vr_shell/vr_shell.cc
diff --git a/chrome/browser/android/vr_shell/vr_shell.cc
b/chrome/browser/android/vr_shell/vr_shell.cc
index
049855683b7f4467971c4447786c09ea36982a8f..2ab08025e195071868ea925690c45965fc282ca0
100644
--- a/chrome/browser/android/vr_shell/vr_shell.cc
+++ b/chrome/browser/android/vr_shell/vr_shell.cc
@@ -9,6 +9,7 @@
 #include "base/threading/thread.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "base/values.h"
 #include "chrome/browser/android/vr_shell/ui_interface.h"
 #include "chrome/browser/android/vr_shell/vr_compositor.h"
 #include "chrome/browser/android/vr_shell/vr_input_manager.h"
@@ -324,23 +325,19 @@ void VrShell::UIBoundsChanged(JNIEnv* env,
   ui_compositor_->SetWindowBounds(width, height);
 }
 
-UiScene* VrShell::GetScene() {
-  GLThread* thread = static_cast<GLThread*>(gl_thread_.get());
-  // TODO(mthiesse): Remove this blocking wait. Queue up events if thread isn't
-  // finished starting?
-  thread->WaitUntilThreadStarted();
-  if (thread->GetVrShellGlUnsafe()) {
-    return thread->GetVrShellGlUnsafe()->GetScene();
-  }
-  return nullptr;
-}
-
 UiInterface* VrShell::GetUiInterface() {
   return html_interface_.get();
 }
 
-void VrShell::QueueTask(base::Callback<void()>& callback) {
-  gl_thread_->task_runner()->PostTask(FROM_HERE, callback);
+void VrShell::UpdateScene(const base::ListValue* args) {
+  GLThread* thread = static_cast<GLThread*>(gl_thread_.get());
+  // TODO(mthiesse): Remove this blocking wait. Queue up events if thread isn't
+  // finished starting?
+  thread->WaitUntilThreadStarted();
+  thread->task_runner()->PostTask(
+      FROM_HERE, base::Bind(&VrShellGl::UpdateScene,
+                            thread->GetVrShellGl(),
+                            base::Passed(args->CreateDeepCopy())));
 }
 
 void VrShell::DoUiAction(const UiAction action) {

[mthiesse, 2016-12-15 15:20:46]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2016-12-15 15:20:46]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2574313002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-15 15:21:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 16:17:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481815246458490,
"parent_rev": "2d73b19a4b211c17239aa8ec87bc2bb25f738b27", "commit_rev":
"e55b46f3ed0e3e88d8c86ea10b43cd4e33b3b520"}

[commit-bot: I haz the power, 2016-12-15 16:18:24]

Description was changed from

==========
Clean up threading around VR Scene updates.

BUG=671302
==========

to

==========
Clean up threading around VR Scene updates.

BUG=671302

Review-Url: https://codereview.chromium.org/2574313002
==========

[commit-bot: I haz the power, 2016-12-15 16:18:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-15 16:21:47]

Description was changed from

==========
Clean up threading around VR Scene updates.

BUG=671302

Review-Url: https://codereview.chromium.org/2574313002
==========

to

==========
Clean up threading around VR Scene updates.

BUG=671302

Committed: https://crrev.com/ae6174ec3aa5ef0db0b68a40bb087e5ab8243b81
Cr-Commit-Position: refs/heads/master@{#438843}
==========

[commit-bot: I haz the power, 2016-12-15 16:21:48]

Patchset 2 (id:??) landed as
https://crrev.com/ae6174ec3aa5ef0db0b68a40bb087e5ab8243b81
Cr-Commit-Position: refs/heads/master@{#438843}