Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2574263002: Change Share Extension string for consistency (Closed)

Created:
4 years ago by gambard
Modified:
4 years ago
Reviewers:
Olivier
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change Share Extension string for consistency This CL changes the Share Extension string from "Add to Reading List" to "Read Later" in order to be consistent with the other usages. BUG=673689 Committed: https://crrev.com/dca2d3d13407eafe6d60103a8dff9e7dfd408926 Cr-Commit-Position: refs/heads/master@{#439443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/share_extension/strings/ios_share_extension_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
gambard
PTAL.
4 years ago (2016-12-14 17:23:57 UTC) #2
gambard
ping
4 years ago (2016-12-19 09:30:47 UTC) #3
Olivier
lgtm
4 years ago (2016-12-19 09:32:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574263002/1
4 years ago (2016-12-19 09:32:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 09:42:21 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dca2d3d13407eafe6d60103a8dff9e7dfd408926 Cr-Commit-Position: refs/heads/master@{#439443}
4 years ago (2016-12-19 09:45:18 UTC) #11
gambard
3 years, 11 months ago (2017-01-02 15:03:58 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2609053002/ by gambard@chromium.org.

The reason for reverting is: Wrong string..

Powered by Google App Engine
This is Rietveld 408576698