Split //ios/chrome/browser/prefs to prevent circular dependencies.

ios/chrome/browser/browser_state/BUILD.gn

Index: ios/chrome/browser/browser_state/BUILD.gn
diff --git a/ios/chrome/browser/browser_state/BUILD.gn b/ios/chrome/browser/browser_state/BUILD.gn
index 50c1e4f7d79d4a183d8341d6c971f05afd96c615..981f523142cdd8082943cf33c4bfb45dd2fc9aa3 100644
--- a/ios/chrome/browser/browser_state/BUILD.gn
+++ b/ios/chrome/browser/browser_state/BUILD.gn
@@ -89,6 +89,7 @@ source_set("browser_state_impl") {
     "//ios/chrome/browser/ntp_snippets",
     "//ios/chrome/browser/passwords",
     "//ios/chrome/browser/prefs",
+    "//ios/chrome/browser/prefs:browser_prefs",
     "//ios/chrome/browser/reading_list",
     "//ios/chrome/browser/search_engines",
     "//ios/chrome/browser/services/gcm",
@@ -107,9 +108,9 @@ source_set("browser_state_impl") {
   ]
   allow_circular_includes_from = [
     "//ios/chrome/browser",
+    "//ios/chrome/browser/prefs:browser_prefs",

[rohitrao (ping after 24h), 2016/12/14 14:54:03]

Sorting?

[sdefresne, 2016/12/14 15:58:03]

I expected "gn format" to have sorted everything. Done.

     "//ios/chrome/browser/browser_state_metrics",
     "//ios/chrome/browser/net",
-    "//ios/chrome/browser/prefs",
     "//ios/chrome/browser/signin",
     "//ios/chrome/browser/sync",
     "//ios/chrome/browser/sync/glue",
@@ -146,6 +147,7 @@ source_set("test_support") {
     "//ios/chrome/browser/history",
     "//ios/chrome/browser/net",
     "//ios/chrome/browser/prefs",
+    "//ios/chrome/browser/prefs:browser_prefs",
     "//ios/chrome/browser/sync/glue",
     "//ios/chrome/test:test_support",
     "//ios/public/provider/chrome/browser",