[TTS] Rework a flaky test to use more robust methodology.

[TTS] Rework a flaky test to use more robust methodology.

Rework testPreventHandlingCurrentSelectionModification to use
simulateLongPressSearch, closePanel, etc.

Hopefully it will be less flaky with these changes.

BUG=673684
Committed: https://crrev.com/eaf56dab37408dfad3152c5e00092ab99f775273
Cr-Commit-Position: refs/heads/master@{#438385}

[Donn Denman, 2016-12-14 00:09:10]

donnd@chromium.org changed reviewers:
+ twellington@chromium.org

[Donn Denman, 2016-12-14 00:09:11]

Theresa, PTAL.

[Theresa, 2016-12-14 00:56:46]

lgtm % nit

https://codereview.chromium.org/2574023002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
(right):

https://codereview.chromium.org/2574023002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java:2032:
waitForPanelToPeek();
simulateLongPressSearch already calls waitForPanelToPeek() so this isn't
necessary.

[Donn Denman, 2016-12-14 01:09:28]

Thanks Theresa!

https://codereview.chromium.org/2574023002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
(right):

https://codereview.chromium.org/2574023002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java:2032:
waitForPanelToPeek();
On 2016/12/14 00:56:46, Theresa Wellington wrote:
> simulateLongPressSearch already calls waitForPanelToPeek() so this isn't
> necessary.

I know, but I thought it would be nice to call it anyway so the reader knows
that we'll assert.  However, a comment seems like a better way to do that.  :-)

Done.

[Donn Denman, 2016-12-14 01:09:33]

The CQ bit was checked by donnd@chromium.org

[Donn Denman, 2016-12-14 01:09:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2574023002/#ps20001
(title: "Changed a waitForPanelToPeek to a comment.")

[commit-bot: I haz the power, 2016-12-14 01:10:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:44:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481677773114480,
"parent_rev": "315eb08cb674714179a4a0a18243cc3f90eb0b44", "commit_rev":
"2026e606931483c5a8cad85758e3632eae265859"}

[commit-bot: I haz the power, 2016-12-14 01:44:46]

Description was changed from

==========
[TTS] Rework a flaky test to use more robust methodology.

Rework testPreventHandlingCurrentSelectionModification to use
simulateLongPressSearch, closePanel, etc.

Hopefully it will be less flaky with these changes.

BUG=673684
==========

to

==========
[TTS] Rework a flaky test to use more robust methodology.

Rework testPreventHandlingCurrentSelectionModification to use
simulateLongPressSearch, closePanel, etc.

Hopefully it will be less flaky with these changes.

BUG=673684

Review-Url: https://codereview.chromium.org/2574023002
==========

[commit-bot: I haz the power, 2016-12-14 01:44:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 01:47:03]

Description was changed from

==========
[TTS] Rework a flaky test to use more robust methodology.

Rework testPreventHandlingCurrentSelectionModification to use
simulateLongPressSearch, closePanel, etc.

Hopefully it will be less flaky with these changes.

BUG=673684

Review-Url: https://codereview.chromium.org/2574023002
==========

to

==========
[TTS] Rework a flaky test to use more robust methodology.

Rework testPreventHandlingCurrentSelectionModification to use
simulateLongPressSearch, closePanel, etc.

Hopefully it will be less flaky with these changes.

BUG=673684

Committed: https://crrev.com/eaf56dab37408dfad3152c5e00092ab99f775273
Cr-Commit-Position: refs/heads/master@{#438385}
==========

[commit-bot: I haz the power, 2016-12-14 01:47:04]

Patchset 2 (id:??) landed as
https://crrev.com/eaf56dab37408dfad3152c5e00092ab99f775273
Cr-Commit-Position: refs/heads/master@{#438385}