Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2574013002: Improve the speech panel's performance (Closed)

Created:
4 years ago by David Tseng
Modified:
4 years ago
Reviewers:
David Tseng
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Improve the speech panel's performance Currently, ChromeVox sends all queued speech output to the speech panel. This unfortunately causes performance issues. For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands. ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly. This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks). BUG=672955 TBR=dtseng@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2570593002 Cr-Commit-Position: refs/heads/master@{#438083} (cherry picked from commit 120bb61b5fd467ef232a893bd7b040fc208ee4c4) Committed: https://chromium.googlesource.com/chromium/src/+/cc01623505fb20e30e21fc34614801be58758e56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js View 3 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
David Tseng
4 years ago (2016-12-13 23:33:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc01623505fb20e30e21fc34614801be58758e56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698