Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2570593002: Improve the speech panel's performance (Closed)

Created:
4 years ago by David Tseng
Modified:
4 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve the speech panel's performance Currently, ChromeVox sends all queued speech output to the speech panel. This unfortunately causes performance issues. For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands. ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly. This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks). BUG=672955 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/120bb61b5fd467ef232a893bd7b040fc208ee4c4 Cr-Commit-Position: refs/heads/master@{#438083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js View 3 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
David Tseng
4 years ago (2016-12-12 18:22:13 UTC) #3
dmazzoni
lgtm
4 years ago (2016-12-12 18:36:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570593002/1
4 years ago (2016-12-12 18:42:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/354630)
4 years ago (2016-12-13 01:43:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570593002/1
4 years ago (2016-12-13 05:38:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 06:27:34 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-13 06:30:09 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/120bb61b5fd467ef232a893bd7b040fc208ee4c4
Cr-Commit-Position: refs/heads/master@{#438083}

Powered by Google App Engine
This is Rietveld 408576698