|
|
Created:
4 years ago by David Tseng Modified:
4 years ago Reviewers:
dmazzoni CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionImprove the speech panel's performance
Currently, ChromeVox sends all queued speech output to the speech panel.
This unfortunately causes performance issues.
For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands.
ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly.
This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks).
BUG=672955
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/120bb61b5fd467ef232a893bd7b040fc208ee4c4
Cr-Commit-Position: refs/heads/master@{#438083}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
Description was changed from ========== Improve the speech panel's performance Currently, ChromeVox sends all queued speech output to the speech panel. This unfortunately causes performance issues. For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands. ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly. This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks). BUG= ========== to ========== Improve the speech panel's performance Currently, ChromeVox sends all queued speech output to the speech panel. This unfortunately causes performance issues. For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands. ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly. This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks). BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org
lgtm
Description was changed from ========== Improve the speech panel's performance Currently, ChromeVox sends all queued speech output to the speech panel. This unfortunately causes performance issues. For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands. ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly. This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks). BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Improve the speech panel's performance Currently, ChromeVox sends all queued speech output to the speech panel. This unfortunately causes performance issues. For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands. ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly. This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks). BUG=672955 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1481607485701810, "parent_rev": "4d5149af9ebd507b9a141ece7e8babf9148575ff", "commit_rev": "8007204efc34e4896e5d0fc38dfc5f4e0723ddb3"}
Message was sent while issue was closed.
Description was changed from ========== Improve the speech panel's performance Currently, ChromeVox sends all queued speech output to the speech panel. This unfortunately causes performance issues. For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands. ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly. This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks). BUG=672955 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Improve the speech panel's performance Currently, ChromeVox sends all queued speech output to the speech panel. This unfortunately causes performance issues. For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands. ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly. This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks). BUG=672955 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2570593002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Improve the speech panel's performance Currently, ChromeVox sends all queued speech output to the speech panel. This unfortunately causes performance issues. For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands. ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly. This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks). BUG=672955 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2570593002 ========== to ========== Improve the speech panel's performance Currently, ChromeVox sends all queued speech output to the speech panel. This unfortunately causes performance issues. For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands. ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly. This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks). BUG=672955 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/120bb61b5fd467ef232a893bd7b040fc208ee4c4 Cr-Commit-Position: refs/heads/master@{#438083} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/120bb61b5fd467ef232a893bd7b040fc208ee4c4 Cr-Commit-Position: refs/heads/master@{#438083} |