[DevTools] Migrate ServiceWorker domain to new generator.

[DevTools] Migrate ServiceWorker domain to new generator.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/b41d221cb138f0f5e3824229f12bf794172e106f
Cr-Commit-Position: refs/heads/master@{#438676}

[dgozman, 2016-12-14 00:53:56]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2016-12-14 00:53:56]

Could you please take a look?

[dgozman, 2016-12-14 06:53:57]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 06:54:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 08:06:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 08:06:15]

Dry run: This issue passed the CQ dry run.

[caseq, 2016-12-14 20:06:25]

lgtm

https://codereview.chromium.org/2573993003/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/service_worker_handler.cc (right):

https://codereview.chromium.org/2573993003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:64: return
ServiceWorker::ServiceWorkerVersionRunningStatusEnum::Stopping;
default: NOTREACHED()?

https://codereview.chromium.org/2573993003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:83: return
ServiceWorker::ServiceWorkerVersionStatusEnum::Redundant;
ditto.

https://codereview.chromium.org/2573993003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:378: if (agent_host)
no need for this check -- though I wonder if GetOrCreateFor() there is
intentional.

[dgozman, 2016-12-14 22:00:01]

https://codereview.chromium.org/2573993003/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/service_worker_handler.cc (right):

https://codereview.chromium.org/2573993003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:64: return
ServiceWorker::ServiceWorkerVersionRunningStatusEnum::Stopping;
On 2016/12/14 20:06:24, caseq wrote:
> default: NOTREACHED()?

Done.

https://codereview.chromium.org/2573993003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:378: if (agent_host)
On 2016/12/14 20:06:24, caseq wrote:
> no need for this check -- though I wonder if GetOrCreateFor() there is
> intentional.

I think it is intentional. Fixed the check.

[dgozman, 2016-12-14 22:00:04]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-12-14 22:00:04]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2573993003/#ps20001
(title: "rebased, review fixes")

[commit-bot: I haz the power, 2016-12-14 22:00:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 22:11:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 22:11:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgozman, 2016-12-14 22:13:04]

Description was changed from

==========
[DevTools] Migrate ServiceWorker domain to new generator.

BUG=664683
==========

to

==========
[DevTools] Migrate ServiceWorker domain to new generator.

BUG=664683
TBR=pfeldman
==========

[dgozman, 2016-12-14 22:13:15]

TBR'ing pfeldman for BUILD.gn

[dgozman, 2016-12-14 22:13:18]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-12-14 22:13:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 23:44:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481753598873240,
"parent_rev": "cbc27d427a16ae578e4532cfc6fb3840937426b1", "commit_rev":
"1f1efcce07fa0e8be3ff2809d812ab50739a1e59"}

[commit-bot: I haz the power, 2016-12-14 23:45:08]

Description was changed from

==========
[DevTools] Migrate ServiceWorker domain to new generator.

BUG=664683
TBR=pfeldman
==========

to

==========
[DevTools] Migrate ServiceWorker domain to new generator.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2573993003
==========

[commit-bot: I haz the power, 2016-12-14 23:45:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 23:47:00]

Description was changed from

==========
[DevTools] Migrate ServiceWorker domain to new generator.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2573993003
==========

to

==========
[DevTools] Migrate ServiceWorker domain to new generator.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/b41d221cb138f0f5e3824229f12bf794172e106f
Cr-Commit-Position: refs/heads/master@{#438676}
==========

[commit-bot: I haz the power, 2016-12-14 23:47:01]

Patchset 2 (id:??) landed as
https://crrev.com/b41d221cb138f0f5e3824229f12bf794172e106f
Cr-Commit-Position: refs/heads/master@{#438676}

[dgozman, 2016-12-15 22:07:08]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2579903002/ by dgozman@chromium.org.

The reason for reverting is: Crashes:
https://bugs.chromium.org/p/chromium/issues/detail?id=674474.

[dgozman, 2016-12-15 22:32:48]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2577233002/ by dgozman@chromium.org.

The reason for reverting is: Speculative.