Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 2573983003: Revert "[ia32] Optimize index calculation for certain checked load/stores." (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
Jarin, shiyu.zhang, bradn
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[ia32] Optimize index calculation for certain checked load/stores." This reverts commit 5c1babcc16e1b568d88af9eb4bc84e050e631039. This seems to regress a range of benchmarks on ia32: Emscripten for Fannkuch, Zlib, MemOps, Life, Bullet AreWeFastYet for BulletLoadTime, Fasta, Fannkuch JetStream for towers.c, quicksort.c, gcc-loops.cpp, bigfib.cpp BUG=673861 R=jarin@chromium.org,shiyu.zhang@intel.com Committed: https://crrev.com/d40195e4f75e44f969b4ee15bf5fd87b383d0292 Cr-Commit-Position: refs/heads/master@{#41696}

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -418 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 3 chunks +58 lines, -383 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +20 lines, -35 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
bradn
4 years ago (2016-12-14 13:39:58 UTC) #3
Jarin
lgtm
4 years ago (2016-12-14 13:57:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573983003/20001
4 years ago (2016-12-14 14:00:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 14:11:31 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-14 14:12:46 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d40195e4f75e44f969b4ee15bf5fd87b383d0292
Cr-Commit-Position: refs/heads/master@{#41696}

Powered by Google App Engine
This is Rietveld 408576698