[SPInvalidation] Update paint properties when border radii change

[SPInvalidation] Update paint properties when border radii change

BUG=645667
TEST=virtual/spinvalidation/compositing/overflow/scroller-with-border-radius.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/50cac7d971b73cc8386c98d0f6a83871d417a15c
Cr-Commit-Position: refs/heads/master@{#438427}

[Xianzhu, 2016-12-13 21:03:44]

Description was changed from

==========
[SPInvalidation] Update paint properties when border radii change

BUG=645667
TEST=virtual/spinvalidation/compositing/overflow/scroller-with-border-radius.html
==========

to

==========
[SPInvalidation] Update paint properties when border radii change

BUG=645667
TEST=virtual/spinvalidation/compositing/overflow/scroller-with-border-radius.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-13 21:03:45]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 21:04:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 21:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 21:14:22]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Xianzhu, 2016-12-13 22:12:09]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2016-12-13 22:12:30]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:13:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-12-13 22:20:08]

Is this broken in SPv1 also?

[Xianzhu, 2016-12-13 22:42:09]

On 2016/12/13 22:20:08, chrishtr wrote:
> Is this broken in SPv1 also?

It's broken for SlimmingPaintInvalidation on SPv1 and SPv2. Not for
non-SlimmingPaintInvalidation.

[chrishtr, 2016-12-13 23:01:16]

On 2016/12/13 at 22:42:09, wangxianzhu wrote:
> On 2016/12/13 22:20:08, chrishtr wrote:
> > Is this broken in SPv1 also?
> 
> It's broken for SlimmingPaintInvalidation on SPv1 and SPv2. Not for
non-SlimmingPaintInvalidation.

I'm curious how so. Is there logic like you're adding here elsewhere?

[Xianzhu, 2016-12-13 23:22:58]

On 2016/12/13 23:01:16, chrishtr wrote:
> On 2016/12/13 at 22:42:09, wangxianzhu wrote:
> > On 2016/12/13 22:20:08, chrishtr wrote:
> > > Is this broken in SPv1 also?
> > 
> > It's broken for SlimmingPaintInvalidation on SPv1 and SPv2. Not for
> non-SlimmingPaintInvalidation.
> 
> I'm curious how so. Is there logic like you're adding here elsewhere?

This CL fixes under-invalidation of paint properties only. This doesn't apply to
non-SlimmingPaintInvalidation.

I guess you are concerning about paint invalidation. This is done by normal
StyleDifference::needsPaintInvalidationObject() logic.

[chrishtr, 2016-12-13 23:32:04]

lgtm

[Xianzhu, 2016-12-14 01:34:06]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-14 01:34:07]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:34:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:51:47]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Xianzhu, 2016-12-14 04:11:08]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-14 04:11:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 04:16:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481688668366730,
"parent_rev": "baf58648e6c82fa8373a2f99be2b15aafa683235", "commit_rev":
"54a420357f7485564c443829ff0c9ae2bd29928c"}

[commit-bot: I haz the power, 2016-12-14 04:17:33]

Description was changed from

==========
[SPInvalidation] Update paint properties when border radii change

BUG=645667
TEST=virtual/spinvalidation/compositing/overflow/scroller-with-border-radius.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Update paint properties when border radii change

BUG=645667
TEST=virtual/spinvalidation/compositing/overflow/scroller-with-border-radius.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2573963002
==========

[commit-bot: I haz the power, 2016-12-14 04:17:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 04:20:37]

Description was changed from

==========
[SPInvalidation] Update paint properties when border radii change

BUG=645667
TEST=virtual/spinvalidation/compositing/overflow/scroller-with-border-radius.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2573963002
==========

to

==========
[SPInvalidation] Update paint properties when border radii change

BUG=645667
TEST=virtual/spinvalidation/compositing/overflow/scroller-with-border-radius.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/50cac7d971b73cc8386c98d0f6a83871d417a15c
Cr-Commit-Position: refs/heads/master@{#438427}
==========

[commit-bot: I haz the power, 2016-12-14 04:20:39]

Patchset 2 (id:??) landed as
https://crrev.com/50cac7d971b73cc8386c98d0f6a83871d417a15c
Cr-Commit-Position: refs/heads/master@{#438427}