Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2573953002: Remove MessagePumpForGpu (Closed)

Created:
4 years ago by stanisc
Modified:
4 years ago
Reviewers:
dcheng
CC:
chromium-reviews, sadrul, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MessagePumpForGpu MessagePumpForGpu isn't needed anymore because all GPU windows have been moved off the main thread and the main GPU thread has been switched to DEFAULT message pump. BUG=671394 Committed: https://crrev.com/1fd3d2d1eb72daeb2df8d02681320159d19a45b4 Cr-Commit-Position: refs/heads/master@{#438319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -173 lines) Patch
M base/message_loop/message_loop_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_win.h View 1 chunk +0 lines, -33 lines 0 comments Download
M base/message_loop/message_pump_win.cc View 1 chunk +0 lines, -137 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
stanisc
PTAL!
4 years ago (2016-12-13 20:11:56 UTC) #4
dcheng
rs lgtm
4 years ago (2016-12-13 22:42:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573953002/1
4 years ago (2016-12-13 22:46:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 22:51:53 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 22:54:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fd3d2d1eb72daeb2df8d02681320159d19a45b4
Cr-Commit-Position: refs/heads/master@{#438319}

Powered by Google App Engine
This is Rietveld 408576698