Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7570)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/vulcanize_gn.py

Issue 2573943002: WebUI: Vulcanize MD Settings at compile time. (Closed)
Patch Set: Nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/settings/about_page/about_page.html ('K') | « chrome/browser/resources/settings/settings_resources_vulcanized.grd ('k') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('j') | ui/webui/resources/cr_elements/icons.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/vulcanize_gn.py
diff --git a/chrome/browser/resources/vulcanize_gn.py b/chrome/browser/resources/vulcanize_gn.py
index d492678b17a239e90c8cebfba857fc0e1755704a..5fc332a58c8c4c4d12901051421c5a1d74aba4df 100755
--- a/chrome/browser/resources/vulcanize_gn.py
+++ b/chrome/browser/resources/vulcanize_gn.py
@@ -155,7 +155,8 @@ def _vulcanize(in_folder, args):
output = _run_node(
[node_modules.PathToVulcanize()] +
_VULCANIZE_BASE_ARGS + _VULCANIZE_REDIRECT_ARGS +
- ['--out-request-list', os.path.join(out_path, _REQUEST_LIST_FILE),
+ ['--out-request-list', os.path.normpath(
+ os.path.join(out_path, _REQUEST_LIST_FILE)),
Dan Beam 2017/02/10 23:14:47 are you going to rebase on calamity@'s "vulcanize
dpapad 2017/02/13 18:53:54 Rebased.
'--redirect', '"/|%s"' % in_path,
'--redirect', '"chrome://%s/|%s"' % (args.host, in_path),
# TODO(dpapad): Figure out why vulcanize treats the input path
« chrome/browser/resources/settings/about_page/about_page.html ('K') | « chrome/browser/resources/settings/settings_resources_vulcanized.grd ('k') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('j') | ui/webui/resources/cr_elements/icons.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698