chrome/browser/resources/vulcanize_gn.py - Issue 2573943002: WebUI: Vulcanize MD Settings at compile time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/vulcanize_gn.py

Issue 2573943002: WebUI: Vulcanize MD Settings at compile time. (Closed)

Patch Set: Rename cr:settings icon to cr:settings_icon to fix global settings object. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/vulcanize_gn.py

diff --git a/chrome/browser/resources/vulcanize_gn.py b/chrome/browser/resources/vulcanize_gn.py

index 0b2df59ac2b0f6ae5b0585090ddc1fcd40f5d4a6..0616c102e61033f573876af2161b4a0ca648574c 100755

--- a/chrome/browser/resources/vulcanize_gn.py

+++ b/chrome/browser/resources/vulcanize_gn.py

@@ -144,7 +144,8 @@ def _vulcanize(in_folder, out_folder, host, html_in_file,

output = _run_node(

[node_modules.PathToVulcanize()] +

_VULCANIZE_BASE_ARGS + _VULCANIZE_REDIRECT_ARGS +

- ['--out-request-list', os.path.join(out_path, _REQUEST_LIST_FILE),

+ ['--out-request-list', os.path.normpath(

+ os.path.join(out_path, _REQUEST_LIST_FILE)),

'--redirect', '"/|%s"' % in_path,

'--redirect', '"chrome://%s/|%s"' % (host, in_path),

# TODO(dpapad): Figure out why vulcanize treats the input path