src/gpu/effects/GrConvolutionEffect.cpp - Issue 257393004: Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrConvolutionEffect.cpp

Issue 257393004: Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: whitespace change Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrConvolutionEffect.cpp

diff --git a/src/gpu/effects/GrConvolutionEffect.cpp b/src/gpu/effects/GrConvolutionEffect.cpp

index 57cdece9d8217f59e58b27c192a2dc3ac540b01f..aad7c878c989ae47a2f0b111243f9fe10a1c1ded 100644

--- a/src/gpu/effects/GrConvolutionEffect.cpp

+++ b/src/gpu/effects/GrConvolutionEffect.cpp

@@ -118,7 +118,7 @@ void GrGLConvolutionEffect::setData(const GrGLUniformManager& uman,

imageIncrement[1] = ySign / texture.height();

break;

default:

- GrCrash("Unknown filter direction.");

+ SkFAIL("Unknown filter direction.");

}

uman.set2fv(fImageIncrementUni, 1, imageIncrement);

if (conv.useBounds()) {