Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2573873002:
Disable HW accelerator for Cast on Android (Closed)
|
Created:
4 years ago by braveyao Modified:
4 years ago Reviewers:
Avi (use Gerrit) CC:
chromium-reviews, posciak+watch_chromium.org, jam, darin-cc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable HW accelerator for Cast on Android
HW accelerator use to be disabled for all on Android. Now we enable H264 HW
accelerator on Android for RTC only in crbug/664652. So keep it disabled for Cast at present.
BUG=664652
Committed: https://crrev.com/6a40d9532e6250b764ca18593c1a4ff1c397b6f8
Cr-Commit-Position: refs/heads/master@{#438335}
Patch Set 1 #
Total comments: 2
Patch Set 2 : address comments #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by braveyao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Disable HW accelerator for Cast on Android HW accelerator use to be disabled for all on Android. Now we enable H264 HW accelerator on Android for RTC only. So keep it disabled for Cast at present. BUG=664652 ========== to ========== Disable HW accelerator for Cast on Android HW accelerator use to be disabled for all on Android. Now we enable H264 HW accelerator on Android for RTC only in crbug/664652. So keep it disabled for Cast at present. BUG=664652 ==========
braveyao@chromium.org changed reviewers: + avi@chromium.org
Hi avi@, please take a look when you get a chance.
lgtm https://codereview.chromium.org/2573873002/diff/1/content/public/renderer/vid... File content/public/renderer/video_encode_accelerator.cc (right): https://codereview.chromium.org/2573873002/diff/1/content/public/renderer/vid... content/public/renderer/video_encode_accelerator.cc:38: // RTC by Default. Keep HW accelerator disalbed for Cast as before at present. typo: disabled https://codereview.chromium.org/2573873002/diff/1/content/public/renderer/vid... content/public/renderer/video_encode_accelerator.cc:41: #endif // defined(OS_ANDROID) Do #else and enclose the other block.
The CQ bit was checked by braveyao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by braveyao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2573873002/#ps20001 (title: "address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481671428971220,
"parent_rev": "072535e7f77182986437703fd68302f5217acd48", "commit_rev":
"39faed6285503d02ddf4a17cf6d3729bcf30f726"}
Message was sent while issue was closed.
Description was changed from ========== Disable HW accelerator for Cast on Android HW accelerator use to be disabled for all on Android. Now we enable H264 HW accelerator on Android for RTC only in crbug/664652. So keep it disabled for Cast at present. BUG=664652 ========== to ========== Disable HW accelerator for Cast on Android HW accelerator use to be disabled for all on Android. Now we enable H264 HW accelerator on Android for RTC only in crbug/664652. So keep it disabled for Cast at present. BUG=664652 Review-Url: https://codereview.chromium.org/2573873002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable HW accelerator for Cast on Android HW accelerator use to be disabled for all on Android. Now we enable H264 HW accelerator on Android for RTC only in crbug/664652. So keep it disabled for Cast at present. BUG=664652 Review-Url: https://codereview.chromium.org/2573873002 ========== to ========== Disable HW accelerator for Cast on Android HW accelerator use to be disabled for all on Android. Now we enable H264 HW accelerator on Android for RTC only in crbug/664652. So keep it disabled for Cast at present. BUG=664652 Committed: https://crrev.com/6a40d9532e6250b764ca18593c1a4ff1c397b6f8 Cr-Commit-Position: refs/heads/master@{#438335} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6a40d9532e6250b764ca18593c1a4ff1c397b6f8 Cr-Commit-Position: refs/heads/master@{#438335} |
