Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2573833002: Revert of Mark org.chromium.android_webview.test.ClientOnPageFinishedTest#testPassesCorrectUrl flaky (Closed)

Created:
4 years ago by boliu
Modified:
4 years ago
Reviewers:
nednguyen
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mark org.chromium.android_webview.test.ClientOnPageFinishedTest#testPassesCorrectUrl flaky (patchset #1 id:1 of https://codereview.chromium.org/2568413003/ ) Reason for revert: Infra problem, not test problem. And the problematic bot has been taken off of cq. Original issue's description: > Mark org.chromium.android_webview.test.ClientOnPageFinishedTest#testPassesCorrectUrl flaky > > BUG=672885 > TBR=boliu@chromium.org > > Committed: https://crrev.com/7d0a2e6fd2a182eb8fa8888cd9539c6072bbf136 > Cr-Commit-Position: refs/heads/master@{#438190} TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672885 Committed: https://crrev.com/9c60403f1326162be69c8f7e7303bb8e9df33efa Cr-Commit-Position: refs/heads/master@{#438191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
boliu
Created Revert of Mark org.chromium.android_webview.test.ClientOnPageFinishedTest#testPassesCorrectUrl flaky
4 years ago (2016-12-13 16:48:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573833002/1
4 years ago (2016-12-13 16:49:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 16:54:44 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 16:57:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c60403f1326162be69c8f7e7303bb8e9df33efa
Cr-Commit-Position: refs/heads/master@{#438191}

Powered by Google App Engine
This is Rietveld 408576698