Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 257383004: Revert 267170 "Use DiscardableMemoryManager on Android." (Closed)

Created:
6 years, 7 months ago by Philippe
Modified:
6 years, 7 months ago
Reviewers:
Philippe
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 267170 "Use DiscardableMemoryManager on Android." > Use DiscardableMemoryManager on Android. > > This allows userspace (DiscardableMemoryManager) to control eviction of > unlocked DiscardableMemory instances to prevent the process from running out of > address space in cases of heavy use of unlocked DiscardableMemory. > > This also removes all the occurences of 'Android' from the ashmem allocator to > allow it to be later used on ChromeOS. > > BUG=327516, 334996 > R=reveman@chromium.org, willchan@chromium.org > > Review URL: https://codereview.chromium.org/195863005 TBR=pliard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -1123 lines) Patch
M trunk/src/base/base.gyp View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/base/base.gypi View 2 chunks +2 lines, -8 lines 0 comments Download
M trunk/src/base/memory/discardable_memory.h View 2 chunks +5 lines, -1 line 0 comments Download
M trunk/src/base/memory/discardable_memory.cc View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/src/base/memory/discardable_memory_allocator_android.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/base/memory/discardable_memory_allocator_android.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/base/memory/discardable_memory_allocator_android_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_android.cc View 5 chunks +16 lines, -26 lines 0 comments Download
D trunk/src/base/memory/discardable_memory_ashmem.h View 1 chunk +0 lines, -55 lines 0 comments Download
D trunk/src/base/memory/discardable_memory_ashmem.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D trunk/src/base/memory/discardable_memory_ashmem_allocator.h View 1 chunk +0 lines, -93 lines 0 comments Download
D trunk/src/base/memory/discardable_memory_ashmem_allocator.cc View 1 chunk +0 lines, -527 lines 0 comments Download
D trunk/src/base/memory/discardable_memory_ashmem_allocator_unittest.cc View 1 chunk +0 lines, -319 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_emulated.h View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_emulated.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_linux.cc View 2 chunks +6 lines, -1 line 0 comments Download
M trunk/src/base/memory/discardable_memory_mac.cc View 2 chunks +6 lines, -1 line 0 comments Download
M trunk/src/base/memory/discardable_memory_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/base/memory/discardable_memory_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/base/memory/discardable_memory_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/base/memory/discardable_memory_unittest.cc View 3 chunks +5 lines, -1 line 0 comments Download
M trunk/src/base/memory/discardable_memory_win.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Philippe
6 years, 7 months ago (2014-04-30 11:15:38 UTC) #1
Philippe
Committed patchset #1 manually as r267175 (tree was closed).
6 years, 7 months ago (2014-04-30 11:15:51 UTC) #2
tomhudson
Why the revert, please?
6 years, 7 months ago (2014-04-30 11:24:27 UTC) #3
Philippe
6 years, 7 months ago (2014-04-30 11:28:02 UTC) #4
Message was sent while issue was closed.
On 2014/04/30 11:24:27, tomhudson wrote:
> Why the revert, please?

So it turns out that the non-clobber Android builder failed at the compile step
but the clobber one did succeed :) It seems that the incremental builder didn't
like the file rename :/

I will find a way to reland this soon anyway.

Powered by Google App Engine
This is Rietveld 408576698