Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2573803002:
Bump CSSFilterEffects pixel test revision number to force rebaseline (Closed)
|
Created:
4 years ago by robertphillips Modified:
4 years ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Jvsquare Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBump CSSFilterEffects pixel test revision number to force rebaseline
This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL)
The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566 on 12/9/2016.
BUG=672527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/6b437a09592f573bf1268f6627c3057d16150a2b
Cr-Commit-Position: refs/heads/master@{#439472}
Patch Set 1 #Patch Set 2 : Update revision #s in correct file #Messages
Total messages: 33 (25 generated)
Description was changed from ========== Bump CSSFilterEffects pixel test revision number to force rebaseline This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL) The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566. BUG=672527 ========== to ========== Bump CSSFilterEffects pixel test revision number to force rebaseline This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL) The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566. BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Bump CSSFilterEffects pixel test revision number to force rebaseline This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL) The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566. BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Bump CSSFilterEffects pixel test revision number to force rebaseline This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL) The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566 on 12/9/2016. BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
robertphillips@google.com changed reviewers: + bajones@chromium.org, fmalita@chromium.org
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
robertphillips@google.com changed reviewers: + kbr@chromium.org
non-owner lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I'm terribly sorry but right now there's some duplication in these files. The actual one you want to modify is src/content/test/gpu/gpu_tests/pixel_test_pages.py . I'll fix this duplication ASAP. (crbug.com/352807)
PTAL - hopefully in correct file now.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
This looks fine but you'll need to suppress Pixel_CSSFilterEffects_NoOverlays in pixel_expectations.py in order for this to land. LGTM if you do that.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/2573803002/#ps20001 (title: "Update revision #s in correct file")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482158422990980,
"parent_rev": "81de4eb46a7039ac933ec529a202242b037a21fe", "commit_rev":
"db022369a72e864b70e3e2c8b34185b27fc68545"}
Message was sent while issue was closed.
Description was changed from ========== Bump CSSFilterEffects pixel test revision number to force rebaseline This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL) The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566 on 12/9/2016. BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Bump CSSFilterEffects pixel test revision number to force rebaseline This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL) The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566 on 12/9/2016. BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2573803002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Bump CSSFilterEffects pixel test revision number to force rebaseline This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL) The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566 on 12/9/2016. BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2573803002 ========== to ========== Bump CSSFilterEffects pixel test revision number to force rebaseline This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL) The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566 on 12/9/2016. BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/6b437a09592f573bf1268f6627c3057d16150a2b Cr-Commit-Position: refs/heads/master@{#439472} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6b437a09592f573bf1268f6627c3057d16150a2b Cr-Commit-Position: refs/heads/master@{#439472} |
