Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2573783002: Remove PreFinalizer{Callback} type aliases from view. (Closed)

Created:
4 years ago by sof
Modified:
4 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PreFinalizer{Callback} type aliases from view. Internal types, no good reason to expose these to the outside. R= BUG=673645 Committed: https://crrev.com/375dffda9aeb0240d96aa44e25c49f2cedc5f22a Cr-Commit-Position: refs/heads/master@{#438170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/heap/BlinkGC.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look.
4 years ago (2016-12-13 12:22:40 UTC) #4
haraken
LGTM
4 years ago (2016-12-13 12:32:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573783002/1
4 years ago (2016-12-13 15:11:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 15:14:58 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 15:18:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/375dffda9aeb0240d96aa44e25c49f2cedc5f22a
Cr-Commit-Position: refs/heads/master@{#438170}

Powered by Google App Engine
This is Rietveld 408576698