Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2573743003: Flatten mash overlay back into Chrome overlay (Closed)

Created:
4 years ago by Ken Rockot(use gerrit already)
Modified:
4 years ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flatten mash overlay back into Chrome overlay Since "mash" is really just a build-time detail of Chrome at this point, roughly equivalent to "Chrome OS", and we don't maintain separate manifest metadata for other conditional platform features, this eliminates one unnecessary layer of overlays by flattening Mash's additional specs into the Chrome overlay. BUG=672614 Committed: https://crrev.com/17441e57d06b74f3abea1f07a6a6115fee611f23 Cr-Commit-Position: refs/heads/master@{#438365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -42 lines) Patch
M chrome/app/mash/BUILD.gn View 2 chunks +0 lines, -11 lines 0 comments Download
D chrome/app/mash/chrome_mash_content_browser_manifest_overlay.json View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/app/mash/chrome_mash_manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/app/mash/mash_service_overrides.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_manifest_overlay.json View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
Ken Rockot(use gerrit already)
4 years ago (2016-12-13 21:50:46 UTC) #3
sky
LGTM
4 years ago (2016-12-13 23:22:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573743003/1
4 years ago (2016-12-13 23:26:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/325298)
4 years ago (2016-12-13 23:37:46 UTC) #11
Ken Rockot(use gerrit already)
+tsepez@ for overlay changes
4 years ago (2016-12-13 23:43:24 UTC) #13
Tom Sepez
lgtm
4 years ago (2016-12-14 00:25:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573743003/1
4 years ago (2016-12-14 00:35:07 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 00:40:48 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-14 00:43:42 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17441e57d06b74f3abea1f07a6a6115fee611f23
Cr-Commit-Position: refs/heads/master@{#438365}

Powered by Google App Engine
This is Rietveld 408576698