Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2573743002: Handle MOJO_RESULT_BUSY result in URLResponseBodyConsumer (Closed)

Created:
4 years ago by yhirano
Modified:
4 years ago
Reviewers:
jam, tzik
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle MOJO_RESULT_BUSY result in URLResponseBodyConsumer URLResponseBodyConsumer reads data from a mojo data pipe and dispatches it as a URLResponseBodyConsumer::ReceivedData. When the dispatched data is destructed, mojo::EndReadDataRaw is called. Until then, mojo::BeginRead will return MOJO_RESULT_BUSY. This CL implements the correct handling for such a case. This mis-handling was the cause of the failure of virtual/mojo-loading/http/tests/inspector/network/network-fetch.html. This CL also adds text() call in makeFetch function so that the backpressure mechanism won't stop the loading. BUG=669357 Committed: https://crrev.com/09721f55334a28503df6bc51cb10f028ebc9f87f Cr-Commit-Position: refs/heads/master@{#438756}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -13 lines) Patch
M content/child/resource_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/url_response_body_consumer.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/child/url_response_body_consumer.cc View 1 4 chunks +15 lines, -3 lines 0 comments Download
M content/child/url_response_body_consumer_unittest.cc View 7 chunks +47 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 30 (20 generated)
yhirano
4 years ago (2016-12-13 10:42:57 UTC) #8
tzik
lgtm
4 years ago (2016-12-13 10:50:01 UTC) #9
jam
lgtm
4 years ago (2016-12-13 17:19:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573743002/1
4 years ago (2016-12-13 17:45:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/278799)
4 years ago (2016-12-13 20:07:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573743002/20001
4 years ago (2016-12-15 02:20:43 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/139167)
4 years ago (2016-12-15 02:25:56 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573743002/20001
4 years ago (2016-12-15 04:14:34 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 05:30:11 UTC) #28
commit-bot: I haz the power
4 years ago (2016-12-15 05:33:43 UTC) #30
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09721f55334a28503df6bc51cb10f028ebc9f87f
Cr-Commit-Position: refs/heads/master@{#438756}

Powered by Google App Engine
This is Rietveld 408576698