Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2573703002: Add PromiseReactionJobInfo to CSA (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
Reviewers:
Benedikt Meurer, ishell
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add PromiseReactionJobInfo to CSA BUG=v8:5343 Committed: https://crrev.com/dfa26606726f21f019231ea085d8dd40e2595bcb Cr-Commit-Position: refs/heads/master@{#41674}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M src/code-stub-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
gsathya
4 years ago (2016-12-13 04:09:41 UTC) #5
Benedikt Meurer
lgtm
4 years ago (2016-12-13 06:18:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573703002/20001
4 years ago (2016-12-13 13:19:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 13:21:20 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-13 13:22:22 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfa26606726f21f019231ea085d8dd40e2595bcb
Cr-Commit-Position: refs/heads/master@{#41674}

Powered by Google App Engine
This is Rietveld 408576698