Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2573683002: Fix leak of HID transfers and handles on Windows. (Closed)

Created:
4 years ago by Reilly Grant (use Gerrit)
Modified:
4 years ago
Reviewers:
juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix leak of HID transfers and handles on Windows. This patch reworks the management of PendingHidTransfer objects in the Windows HID backend so that they are no longer reference counted. It then adds logic to free all transfers when the device handle is closed in order to break the circular reference between transfers and the connection object. BUG=618213 Committed: https://crrev.com/e62aec48485940cb4e214dd8f6845ebc89f20dee Cr-Commit-Position: refs/heads/master@{#438374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -87 lines) Patch
M device/hid/hid_connection_win.h View 4 chunks +7 lines, -4 lines 0 comments Download
M device/hid/hid_connection_win.cc View 10 chunks +80 lines, -83 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years ago (2016-12-13 01:12:34 UTC) #4
juncai
LGTM.
4 years ago (2016-12-14 00:54:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573683002/1
4 years ago (2016-12-14 01:05:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 01:12:52 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 01:15:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e62aec48485940cb4e214dd8f6845ebc89f20dee
Cr-Commit-Position: refs/heads/master@{#438374}

Powered by Google App Engine
This is Rietveld 408576698