Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2573653002: Fix how Hydrogen traces inlined functions. (Closed)

Created:
4 years ago by Vyacheslav Egorov (Google)
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix how Hydrogen traces inlined functions. https://crrev.com/c3a6ca68d0646b10885ef7017557eaf463db2e4a changed what kind of information is dumped which broke some properties of the output that IRHydra relies on: 1. Because IRHydra does not have access to the whole scripts it relies on function sources dumps to map IR and deoptimization to the actual source. This means that source positions must be dumped in a way that allows for this mapping and previously we used positions relative to the beginning of the function to allow that. Now we are dumping absolute script positions which means that function sources must be annotated with the start position so that IRHydra (or any other similar tools) could translate absolute script positions into function-relative ones. 2. When dumping inlined functions we should dump which function are we inlining into because position itself is not enough to recover the inlining stack from the output. BUG= Committed: https://crrev.com/7371284dcf57c7b13a5398ab4764362b869aa61e Cr-Commit-Position: refs/heads/master@{#41663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/crankshaft/hydrogen.cc View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Vyacheslav Egorov (Google)
PTAL
4 years ago (2016-12-12 22:58:50 UTC) #2
Benedikt Meurer
lgtm
4 years ago (2016-12-13 06:10:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573653002/1
4 years ago (2016-12-13 06:42:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 07:30:30 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-13 07:31:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7371284dcf57c7b13a5398ab4764362b869aa61e
Cr-Commit-Position: refs/heads/master@{#41663}

Powered by Google App Engine
This is Rietveld 408576698