Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2573633002:
🎋 Android: Use both versionCode and lastUpdateTime for change-detection (Closed)
|
Created:
4 years ago by agrieve Modified:
4 years ago Reviewers:
vabr (Chromium) CC:
chromium-reviews, agrieve+watch_chromium.org, vmpstr+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAndroid: Use both versionCode and lastUpdateTime for change-detection
I haven't gone through the (obscure) steps to repro the failure, but
this change is easy enough and I can't see how it could hurt anything.
BUG=673458
Committed: https://crrev.com/3ceb34ed05b1ba1240e34ebc8f268a7049ddb7af
Cr-Commit-Position: refs/heads/master@{#438263}
Patch Set 1 #Patch Set 2 : cast before shift #Messages
Total messages: 17 (12 generated)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Description was changed from ========== Android: Use both versionCode and lastUpdateTime for change-detection BUG=673458 ========== to ========== Android: Use both versionCode and lastUpdateTime for change-detection BUG=673458 ==========
agrieve@chromium.org changed reviewers: + vabr@chromium.org
On 2016/12/12 20:50:04, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:vabr@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Android: Use both versionCode and lastUpdateTime for change-detection BUG=673458 ========== to ========== Android: Use both versionCode and lastUpdateTime for change-detection I haven't gone through the (obscure) steps to repro the failure, but this change is easy enough and I can't see how it could hurt anything. BUG=673458 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
Thanks for the patch! I have to trust your knowledge of the code, in particular for both versionCode and lastUpdateTime fitting each in 32 bits. But in general the change sounds good, the comment is clear. LGTM. Cheers, Vaclav
The CQ bit was checked by agrieve@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org Link to the patchset: https://codereview.chromium.org/2573633002/#ps20001 (title: "cast before shift")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481655443592090,
"parent_rev": "68e5acd969d178a4e4a2c2f27680ae90d41d323d", "commit_rev":
"b1d7c627b80153a7bd5b55e278c91a0e426bc34f"}
Message was sent while issue was closed.
Description was changed from ========== Android: Use both versionCode and lastUpdateTime for change-detection I haven't gone through the (obscure) steps to repro the failure, but this change is easy enough and I can't see how it could hurt anything. BUG=673458 ========== to ========== Android: Use both versionCode and lastUpdateTime for change-detection I haven't gone through the (obscure) steps to repro the failure, but this change is easy enough and I can't see how it could hurt anything. BUG=673458 Review-Url: https://codereview.chromium.org/2573633002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Android: Use both versionCode and lastUpdateTime for change-detection I haven't gone through the (obscure) steps to repro the failure, but this change is easy enough and I can't see how it could hurt anything. BUG=673458 Review-Url: https://codereview.chromium.org/2573633002 ========== to ========== Android: Use both versionCode and lastUpdateTime for change-detection I haven't gone through the (obscure) steps to repro the failure, but this change is easy enough and I can't see how it could hurt anything. BUG=673458 Committed: https://crrev.com/3ceb34ed05b1ba1240e34ebc8f268a7049ddb7af Cr-Commit-Position: refs/heads/master@{#438263} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3ceb34ed05b1ba1240e34ebc8f268a7049ddb7af Cr-Commit-Position: refs/heads/master@{#438263} |
