Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2573613002:
Shrink onResourcesLoaded() code size in webview/monochrome R.java (Closed)
DescriptionShrink onResourcesLoaded() code size in webview/monochrome R.java.
Shrinks code size in webview/monochrome R.java by rewriting the
template for onResourcesLoaded(). Uses xor instead of masking to
transform the fields.
See attached bug link for discussion and details.
BUG=669137
Committed: https://crrev.com/b10563e0715c0c61e503f5ef285c5a0652ae583f
Cr-Commit-Position: refs/heads/master@{#438229}
Patch Set 1 : Format #
Total comments: 6
Patch Set 2 : Addressing comments #Messages
Total messages: 22 (14 generated)
The CQ bit was checked by zpeng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== DO NOT SUBMIT shrink R.java by using xor BUG= ========== to ========== Shrink onResourcesLoaded() code size in webview/monochrome R.java. Shrinks code size in webview/monochrome R.java by rewriting the template for onResourcesLoaded(). Uses xor instead of masking to transform the fields. See attached bug link for discussion and details. BUG=669137 ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by zpeng@chromium.org to run a CQ dry run
zpeng@chromium.org changed reviewers: + agrieve@chromium.org
Hi Andrew, PTAL. Thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
just nits. lgtm https://codereview.chromium.org/2573613002/diff/20001/build/android/gyp/proce... File build/android/gyp/process_resources.py (right): https://codereview.chromium.org/2573613002/diff/20001/build/android/gyp/proce... build/android/gyp/process_resources.py:202: create_id = ('{{ e.resource_type }}.{{ e.name }} = ' nit: could now shorten these with ^= https://codereview.chromium.org/2573613002/diff/20001/build/android/gyp/proce... build/android/gyp/process_resources.py:243: private static boolean sResourcesDidLoad; nit: can you move this to come at the top of the class (line 216) https://codereview.chromium.org/2573613002/diff/20001/build/android/gyp/proce... build/android/gyp/process_resources.py:246: int packageIdTransform) { nit: indent 4 more spaces
Thanks Andrew! PTAL Submitting soon https://codereview.chromium.org/2573613002/diff/20001/build/android/gyp/proce... File build/android/gyp/process_resources.py (right): https://codereview.chromium.org/2573613002/diff/20001/build/android/gyp/proce... build/android/gyp/process_resources.py:202: create_id = ('{{ e.resource_type }}.{{ e.name }} = ' On 2016/12/12 20:40:51, agrieve wrote: > nit: could now shorten these with ^= Done. https://codereview.chromium.org/2573613002/diff/20001/build/android/gyp/proce... build/android/gyp/process_resources.py:243: private static boolean sResourcesDidLoad; On 2016/12/12 20:40:51, agrieve wrote: > nit: can you move this to come at the top of the class (line 216) Done. https://codereview.chromium.org/2573613002/diff/20001/build/android/gyp/proce... build/android/gyp/process_resources.py:246: int packageIdTransform) { On 2016/12/12 20:40:51, agrieve wrote: > nit: indent 4 more spaces Done.
The CQ bit was checked by zpeng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2573613002/#ps40001 (title: "Addressing comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by zpeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481651345140600,
"parent_rev": "2331538832b54f0cee7c03e20c5cbc2c5e88820c", "commit_rev":
"81c88e2bec453c2aff3b25093eea827102391ec0"}
Message was sent while issue was closed.
Description was changed from ========== Shrink onResourcesLoaded() code size in webview/monochrome R.java. Shrinks code size in webview/monochrome R.java by rewriting the template for onResourcesLoaded(). Uses xor instead of masking to transform the fields. See attached bug link for discussion and details. BUG=669137 ========== to ========== Shrink onResourcesLoaded() code size in webview/monochrome R.java. Shrinks code size in webview/monochrome R.java by rewriting the template for onResourcesLoaded(). Uses xor instead of masking to transform the fields. See attached bug link for discussion and details. BUG=669137 Review-Url: https://codereview.chromium.org/2573613002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Shrink onResourcesLoaded() code size in webview/monochrome R.java. Shrinks code size in webview/monochrome R.java by rewriting the template for onResourcesLoaded(). Uses xor instead of masking to transform the fields. See attached bug link for discussion and details. BUG=669137 Review-Url: https://codereview.chromium.org/2573613002 ========== to ========== Shrink onResourcesLoaded() code size in webview/monochrome R.java. Shrinks code size in webview/monochrome R.java by rewriting the template for onResourcesLoaded(). Uses xor instead of masking to transform the fields. See attached bug link for discussion and details. BUG=669137 Committed: https://crrev.com/b10563e0715c0c61e503f5ef285c5a0652ae583f Cr-Commit-Position: refs/heads/master@{#438229} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b10563e0715c0c61e503f5ef285c5a0652ae583f Cr-Commit-Position: refs/heads/master@{#438229} |
