[Cronet] Copy certificates before using in tests

[Cronet] Copy certificates before using in tests

If you try and run some tests by themselves they may fail because
the certificate files have not been extracted from the APK
assets.  Make sure the files are extracted before use.
Without this change some tests only pass because prior tests
have already extracted the files.  Tests should not be dependent
on other tests.

BUG=629299
R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/baf304cf99d2c59cf56af685df7bf18091298370
Cr-Commit-Position: refs/heads/master@{#437918}

[pauljensen, 2016-12-12 18:10:09]

Description was changed from

==========
[Cronet] Copy certificates before using in tests

If you try and run some tests by themselves they may fail because
the certificate files have not been extracted from the APK
assets.  Make sure the files are extracted before use.
Without this change some tests only pass because prior tests
have already extracted the files.  Tests should not be dependent
on other tests.

BUG=629299
R=xunjieli
==========

to

==========
[Cronet] Copy certificates before using in tests

If you try and run some tests by themselves they may fail because
the certificate files have not been extracted from the APK
assets.  Make sure the files are extracted before use.
Without this change some tests only pass because prior tests
have already extracted the files.  Tests should not be dependent
on other tests.

BUG=629299
R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2016-12-12 18:10:39]

Helen, PTAL, thank you!

[xunjieli, 2016-12-12 19:37:21]

https://codereview.chromium.org/2573483003/diff/1/components/cronet/android/t...
File components/cronet/android/test/src/org/chromium/net/QuicTestServer.java
(right):

https://codereview.chromium.org/2573483003/diff/1/components/cronet/android/t...
components/cronet/android/test/src/org/chromium/net/QuicTestServer.java:77:
TestFilesInstaller.installIfNeeded(ContextUtils.getApplicationContext());
startQuicTestServer() already calls installIfNeeded(). Is it enough?

[pauljensen, 2016-12-12 19:52:42]

https://codereview.chromium.org/2573483003/diff/1/components/cronet/android/t...
File components/cronet/android/test/src/org/chromium/net/QuicTestServer.java
(right):

https://codereview.chromium.org/2573483003/diff/1/components/cronet/android/t...
components/cronet/android/test/src/org/chromium/net/QuicTestServer.java:77:
TestFilesInstaller.installIfNeeded(ContextUtils.getApplicationContext());
On 2016/12/12 19:37:21, xunjieli wrote:
> startQuicTestServer() already calls installIfNeeded(). Is it enough? 

No, this a public API with no documented or enforced ordering requirements.
Tests call QuicTestServer.createMockCertVerifier() without starting a
QuicTestServer, for example all BidirectionalStreamTest's use the setUp()
function which does not start a QuicServer but calls
QuicTestServer.createMockCertVerifier().

[xunjieli, 2016-12-12 20:05:44]

lgtm

[pauljensen, 2016-12-12 20:06:28]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2016-12-12 20:07:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 21:31:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481573188865830, "parent_rev":
"9b4fe32e2158453c75ad66f623f9daf8e9053887", "commit_rev":
"3024300f3abebdcde90229071b8b6dfc0d18a19b"}

[commit-bot: I haz the power, 2016-12-12 21:35:13]

Description was changed from

==========
[Cronet] Copy certificates before using in tests

If you try and run some tests by themselves they may fail because
the certificate files have not been extracted from the APK
assets.  Make sure the files are extracted before use.
Without this change some tests only pass because prior tests
have already extracted the files.  Tests should not be dependent
on other tests.

BUG=629299
R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Copy certificates before using in tests

If you try and run some tests by themselves they may fail because
the certificate files have not been extracted from the APK
assets.  Make sure the files are extracted before use.
Without this change some tests only pass because prior tests
have already extracted the files.  Tests should not be dependent
on other tests.

BUG=629299
R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/baf304cf99d2c59cf56af685df7bf18091298370
Cr-Commit-Position: refs/heads/master@{#437918}
==========

[commit-bot: I haz the power, 2016-12-12 21:35:14]

Patchset 1 (id:??) landed as
https://crrev.com/baf304cf99d2c59cf56af685df7bf18091298370
Cr-Commit-Position: refs/heads/master@{#437918}