[Cronet] Copy certificates before using in tests

components/cronet/android/test/src/org/chromium/net/QuicTestServer.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.content.Context;
 import android.os.ConditionVariable;
 
+import org.chromium.base.ContextUtils;
 import org.chromium.base.Log;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.JNINamespace;
 import org.chromium.base.test.util.UrlUtils;
 
 /**
  * Wrapper class to start a Quic test server.
  */
 @JNINamespace("cronet")
 public final class QuicTestServer {
@@ skipping 46 matching lines @@
 
     public static final String getServerCert() {
         return CERT_USED;
     }
 
     public static final String getServerCertKey() {
         return KEY_USED;
     }
 
     public static long createMockCertVerifier() {
+        TestFilesInstaller.installIfNeeded(ContextUtils.getApplicationContext());

[xunjieli, 2016/12/12 19:37:21]

startQuicTestServer() already calls installIfNeeded(). Is it enough? 

[pauljensen, 2016/12/12 19:52:42]

No, this a public API with no documented or enforced ordering requirements.
Tests call QuicTestServer.createMockCertVerifier() without starting a
QuicTestServer, for example all BidirectionalStreamTest's use the setUp()
function which does not start a QuicServer but calls
QuicTestServer.createMockCertVerifier().

         return MockCertVerifier.createMockCertVerifier(CERTS_USED, true);
     }
 
     @CalledByNative
     private static void onServerStarted() {
         Log.i(TAG, "Quic server started.");
         sBlock.open();
     }
 
     private static native void nativeStartQuicTestServer(String filePath, String testDataDir);
     private static native void nativeShutdownQuicTestServer();
     private static native int nativeGetServerPort();
 }