Reland of Enable RL by default

Reland of Enable RL by default

Reland of https://codereview.chromium.org/2562643003/ after fixing the
issue.

BUG=577659
Committed: https://crrev.com/06e983db9148e48240a93cf44407296b6ca267dd
Cr-Commit-Position: refs/heads/master@{#438100}

[Olivier, 2016-12-12 15:23:40]

olivierrobin@chromium.org changed reviewers:
+ noyau@chromium.org, sdefresne@chromium.org

[Olivier, 2016-12-12 15:23:41]

Relanding https://codereview.chromium.org/2562643003/ did not work.
So creating another CL.

[Olivier, 2016-12-12 15:23:46]

The CQ bit was checked by olivierrobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 15:24:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-12 15:28:29]

lgtm

[noyau (Ping after 24h), 2016-12-12 15:48:50]

https://codereview.chromium.org/2573473002/diff/20001/components/reading_list...
File components/reading_list/core/reading_list.gni (right):

https://codereview.chromium.org/2573473002/diff/20001/components/reading_list...
components/reading_list/core/reading_list.gni:8: enable_reading_list = true
Maybe I'm confused, but this file is not iOS specific and turns the feature on.
Should it turn it off on other platforms?

[noyau (Ping after 24h), 2016-12-12 15:50:09]

https://codereview.chromium.org/2573473002/diff/20001/ios/chrome/browser/sync...
File ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory_unittest.cc
(right):

https://codereview.chromium.org/2573473002/diff/20001/ios/chrome/browser/sync...
ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory_unittest.cc:48:
datatypes.push_back(syncer::READING_LIST);
Should this be driven by the build flag as well?

[commit-bot: I haz the power, 2016-12-12 17:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 17:11:50]

Dry run: This issue passed the CQ dry run.

[Olivier, 2016-12-12 17:55:58]

https://codereview.chromium.org/2573473002/diff/20001/components/reading_list...
File components/reading_list/core/reading_list.gni (right):

https://codereview.chromium.org/2573473002/diff/20001/components/reading_list...
components/reading_list/core/reading_list.gni:8: enable_reading_list = true
On 2016/12/12 15:48:50, noyau wrote:
> Maybe I'm confused, but this file is not iOS specific and turns the feature
on.
> Should it turn it off on other platforms?

That is what I tried first, but it is not possible to test the platform in
declare_ergs.
sdefresne advice is to put true here and test the platform in the BUILD.gn file

https://codereview.chromium.org/2573473002/diff/20001/ios/chrome/browser/sync...
File ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory_unittest.cc
(right):

https://codereview.chromium.org/2573473002/diff/20001/ios/chrome/browser/sync...
ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory_unittest.cc:48:
datatypes.push_back(syncer::READING_LIST);
On 2016/12/12 15:50:09, noyau wrote:
> Should this be driven by the build flag as well?

Done.

[Olivier, 2016-12-12 17:56:36]

The CQ bit was checked by olivierrobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 17:56:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Olivier, 2016-12-12 20:03:56]

The CQ bit was unchecked by olivierrobin@chromium.org

[Olivier, 2016-12-12 20:04:02]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2016-12-12 20:04:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2573473002/#ps40001
(title: "add guard")

[commit-bot: I haz the power, 2016-12-12 20:04:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Olivier, 2016-12-12 20:40:20]

The CQ bit was unchecked by olivierrobin@chromium.org

[Olivier, 2016-12-12 20:40:34]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2016-12-12 20:42:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:52:10]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Olivier, 2016-12-13 07:43:22]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2016-12-13 07:43:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 08:29:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481615002383940,
"parent_rev": "1eb803a82844fe72efb9a2f2bb1f2bb7210b0d87", "commit_rev":
"0cc7d81f7c64bd22b92bccdbfa5f5080befb1054"}

[commit-bot: I haz the power, 2016-12-13 08:29:39]

Description was changed from

==========
Reland of Enable RL by default

Reland of https://codereview.chromium.org/2562643003/ after fixing the
issue.

BUG=577659
==========

to

==========
Reland of Enable RL by default

Reland of https://codereview.chromium.org/2562643003/ after fixing the
issue.

BUG=577659

Review-Url: https://codereview.chromium.org/2573473002
==========

[commit-bot: I haz the power, 2016-12-13 08:29:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 08:32:16]

Description was changed from

==========
Reland of Enable RL by default

Reland of https://codereview.chromium.org/2562643003/ after fixing the
issue.

BUG=577659

Review-Url: https://codereview.chromium.org/2573473002
==========

to

==========
Reland of Enable RL by default

Reland of https://codereview.chromium.org/2562643003/ after fixing the
issue.

BUG=577659

Committed: https://crrev.com/06e983db9148e48240a93cf44407296b6ca267dd
Cr-Commit-Position: refs/heads/master@{#438100}
==========

[commit-bot: I haz the power, 2016-12-13 08:32:17]

Patchset 3 (id:??) landed as
https://crrev.com/06e983db9148e48240a93cf44407296b6ca267dd
Cr-Commit-Position: refs/heads/master@{#438100}