CSS Animations: More layout tests use testharness.js

CSS Animations: More layout tests use testharness.js

The following tests now use testharness.js:
  animation-direction-alternate.html
  animation-direction-alternate-reverse.html
  animation-direction-reverse-fill-mode.html
  animation-direction-reverse-non-hardware.html
  animation-direction-reverse-timing-functions.html

BUG=674123
Committed: https://crrev.com/7b033bfa43bdf3bcdbeb6a9d9742dcf26346830b
Cr-Commit-Position: refs/heads/master@{#439033}

[Eric Willigers, 2016-12-15 06:30:44]

Description was changed from

==========
CSS Animations: More layout tests use testharness.js

The following tests now use testharness.js:
  animation-direction-alternate.html
  animation-direction-alternate-reverse.html
  animation-direction-reverse-fill-mode.html

BUG=674123
==========

to

==========
CSS Animations: More layout tests use testharness.js

The following tests now use testharness.js:
  animation-direction-alternate.html
  animation-direction-alternate-reverse.html
  animation-direction-reverse-fill-mode.html
  animation-direction-reverse-non-hardware.html
  animation-direction-reverse-timing-functions.html

BUG=674123
==========

[Eric Willigers, 2016-12-15 06:30:45]

ericwilligers@chromium.org changed reviewers:
+ suzyh@chromium.org

[Eric Willigers, 2016-12-15 06:31:01]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 06:31:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 07:45:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 07:45:12]

Dry run: This issue passed the CQ dry run.

[suzyh_UTC10 (ex-contributor), 2016-12-15 23:57:28]

I haven't read the test expectations in detail to confirm that the old and new
test values are all the same. Consider doing a sanity check by eyeballing the
test files themselves or intentionally introducing a bug into the code.

Are any of these tests redundant with the imported/wpt/web-animations tests?

https://codereview.chromium.org/2573413002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/animation-direction-reverse-fill-mode.html
(right):

https://codereview.chromium.org/2573413002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/animation-direction-reverse-fill-mode.html:37:
#both_iterating {
Should these alternate and alternate-reverse tests be moved to the other test
files?

https://codereview.chromium.org/2573413002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/animation-direction-reverse-timing-functions.html
(right):

https://codereview.chromium.org/2573413002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/animation-direction-reverse-timing-functions.html:50:
assert_equals(getComputedStyle(box1).left, '18.6525px');
Are these values likely to be flaky at all? Should this be an approx equals test
instead?

[Eric Willigers, 2016-12-16 00:36:17]

> sanity check by ... intentionally introducing a bug

Each of the test fails if I make minor expectation changes.

https://codereview.chromium.org/2573413002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/animation-direction-reverse-timing-functions.html
(right):

https://codereview.chromium.org/2573413002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/animation-direction-reverse-timing-functions.html:50:
assert_equals(getComputedStyle(box1).left, '18.6525px');
On 2016/12/15 23:57:28, suzyh wrote:
> Are these values likely to be flaky at all? Should this be an approx equals
test
> instead?

Changed to use assert_approx_equals.

They shouldn't be flaky as the time is explicit.

They would change if our Bezier implementation changes.

[Eric Willigers, 2016-12-16 00:53:19]

> Are any of these tests redundant with the imported/wpt/web-animations tests?

I don't think so. These tests use CSS Animations.

https://codereview.chromium.org/2573413002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/animation-direction-reverse-fill-mode.html
(right):

https://codereview.chromium.org/2573413002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/animation-direction-reverse-fill-mode.html:37:
#both_iterating {
On 2016/12/15 23:57:28, suzyh wrote:
> Should these alternate and alternate-reverse tests be moved to the other test
> files?

Done.

[suzyh_UTC10 (ex-contributor), 2016-12-16 02:55:40]

lgtm


On 2016/12/16 at 00:53:19, ericwilligers wrote:
> > Are any of these tests redundant with the imported/wpt/web-animations tests?
> 
> I don't think so. These tests use CSS Animations.

Oh yeah, good point, haha.

[Eric Willigers, 2016-12-16 03:03:48]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 03:04:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 05:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 05:07:33]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-12-16 05:10:42]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-12-16 05:11:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 05:27:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481865042858030,
"parent_rev": "7a353cdeadb230659c2bc0902ca4065b82377faf", "commit_rev":
"570b6bcecd27755c9b2bfe2c080df92802cbfbce"}

[commit-bot: I haz the power, 2016-12-16 05:28:07]

Description was changed from

==========
CSS Animations: More layout tests use testharness.js

The following tests now use testharness.js:
  animation-direction-alternate.html
  animation-direction-alternate-reverse.html
  animation-direction-reverse-fill-mode.html
  animation-direction-reverse-non-hardware.html
  animation-direction-reverse-timing-functions.html

BUG=674123
==========

to

==========
CSS Animations: More layout tests use testharness.js

The following tests now use testharness.js:
  animation-direction-alternate.html
  animation-direction-alternate-reverse.html
  animation-direction-reverse-fill-mode.html
  animation-direction-reverse-non-hardware.html
  animation-direction-reverse-timing-functions.html

BUG=674123

Review-Url: https://codereview.chromium.org/2573413002
==========

[commit-bot: I haz the power, 2016-12-16 05:28:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-16 05:30:32]

Description was changed from

==========
CSS Animations: More layout tests use testharness.js

The following tests now use testharness.js:
  animation-direction-alternate.html
  animation-direction-alternate-reverse.html
  animation-direction-reverse-fill-mode.html
  animation-direction-reverse-non-hardware.html
  animation-direction-reverse-timing-functions.html

BUG=674123

Review-Url: https://codereview.chromium.org/2573413002
==========

to

==========
CSS Animations: More layout tests use testharness.js

The following tests now use testharness.js:
  animation-direction-alternate.html
  animation-direction-alternate-reverse.html
  animation-direction-reverse-fill-mode.html
  animation-direction-reverse-non-hardware.html
  animation-direction-reverse-timing-functions.html

BUG=674123

Committed: https://crrev.com/7b033bfa43bdf3bcdbeb6a9d9742dcf26346830b
Cr-Commit-Position: refs/heads/master@{#439033}
==========

[commit-bot: I haz the power, 2016-12-16 05:30:33]

Patchset 3 (id:??) landed as
https://crrev.com/7b033bfa43bdf3bcdbeb6a9d9742dcf26346830b
Cr-Commit-Position: refs/heads/master@{#439033}