chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc ('k') | chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

index 9bf13269f1d876816e6144c735cf4c4dc12d2156..c6b6606bd3fd3ad88a1c4232fd367086a0bbf690 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

@@ -36,7 +36,7 @@ class WebrtcLoggingPrivateSetMetaDataFunction

virtual ~WebrtcLoggingPrivateSetMetaDataFunction();

// ExtensionFunction overrides.

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// Must be called on UI thread.

void SetMetaDataCallback(bool success, const std::string& error_message);

@@ -53,7 +53,7 @@ class WebrtcLoggingPrivateStartFunction

virtual ~WebrtcLoggingPrivateStartFunction();

// ExtensionFunction overrides.

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// Must be called on UI thread.

void StartCallback(bool success, const std::string& error_message);

@@ -70,7 +70,7 @@ class WebrtcLoggingPrivateSetUploadOnRenderCloseFunction

virtual ~WebrtcLoggingPrivateSetUploadOnRenderCloseFunction();

// ExtensionFunction overrides.

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

};

class WebrtcLoggingPrivateStopFunction

@@ -84,7 +84,7 @@ class WebrtcLoggingPrivateStopFunction

virtual ~WebrtcLoggingPrivateStopFunction();

// ExtensionFunction overrides.

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// Must be called on UI thread.

void StopCallback(bool success, const std::string& error_message);

@@ -101,7 +101,7 @@ class WebrtcLoggingPrivateUploadFunction

virtual ~WebrtcLoggingPrivateUploadFunction();

// ExtensionFunction overrides.

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// Must be called on UI thread.

void UploadCallback(bool success, const std::string& report_id,

@@ -119,7 +119,7 @@ class WebrtcLoggingPrivateDiscardFunction

virtual ~WebrtcLoggingPrivateDiscardFunction();

// ExtensionFunction overrides.

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// Must be called on UI thread.

void DiscardCallback(bool success, const std::string& error_message);