Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2689)

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
index 6d4c178c9c954bf2bf92f5b6781703b7dfd91d20..0edc00bb8342389fa302c7a97b584257abe89202 100644
--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
@@ -204,7 +204,7 @@ content::ResourceContext* WebrtcAudioPrivateFunction::resource_context() const {
return resource_context_;
}
-bool WebrtcAudioPrivateGetSinksFunction::RunImpl() {
+bool WebrtcAudioPrivateGetSinksFunction::RunAsync() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
InitResourceContext();
@@ -233,7 +233,7 @@ void WebrtcAudioPrivateGetSinksFunction::OnOutputDeviceNames(
// normally runs) because there is one instance of this object per
// function call, no actor outside of this object is modifying the
// results_ member, and the different method invocations on this
- // object run strictly in sequence; first RunImpl on the UI thread,
+ // object run strictly in sequence; first RunAsync on the UI thread,
// then DoQuery on the audio IO thread, then DoneOnUIThread on the
// UI thread.
results_.reset(wap::GetSinks::Results::Create(results).release());
@@ -248,7 +248,7 @@ void WebrtcAudioPrivateGetSinksFunction::DoneOnUIThread() {
SendResponse(true);
}
-bool WebrtcAudioPrivateGetActiveSinkFunction::RunImpl() {
+bool WebrtcAudioPrivateGetActiveSinkFunction::RunAsync() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
InitResourceContext();
@@ -306,7 +306,7 @@ WebrtcAudioPrivateSetActiveSinkFunction::
~WebrtcAudioPrivateSetActiveSinkFunction() {
}
-bool WebrtcAudioPrivateSetActiveSinkFunction::RunImpl() {
+bool WebrtcAudioPrivateSetActiveSinkFunction::RunAsync() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
scoped_ptr<wap::SetActiveSink::Params> params(
wap::SetActiveSink::Params::Create(*args_));
@@ -391,7 +391,7 @@ WebrtcAudioPrivateGetAssociatedSinkFunction::
~WebrtcAudioPrivateGetAssociatedSinkFunction() {
}
-bool WebrtcAudioPrivateGetAssociatedSinkFunction::RunImpl() {
+bool WebrtcAudioPrivateGetAssociatedSinkFunction::RunAsync() {
params_ = wap::GetAssociatedSink::Params::Create(*args_);
DCHECK_CURRENTLY_ON(BrowserThread::UI);
EXTENSION_FUNCTION_VALIDATE(params_.get());

Powered by Google App Engine
This is Rietveld 408576698