chrome/browser/extensions/api/identity/identity_api.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/identity/identity_api.h

diff --git a/chrome/browser/extensions/api/identity/identity_api.h b/chrome/browser/extensions/api/identity/identity_api.h

index 79b5ee054616c5fbdb6de94a2658ec3eaac7149c..a4346208a21601824630c55517511ae8a97395ae 100644

--- a/chrome/browser/extensions/api/identity/identity_api.h

+++ b/chrome/browser/extensions/api/identity/identity_api.h

@@ -184,7 +184,7 @@ class IdentityGetAuthTokenFunction : public ChromeAsyncExtensionFunction,

friend class MockGetAuthTokenFunction;

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// Helpers to report async function results to the caller.

void StartAsyncRun();

@@ -300,7 +300,7 @@ class IdentityLaunchWebAuthFlowFunction : public ChromeAsyncExtensionFunction,

private:

virtual ~IdentityLaunchWebAuthFlowFunction();

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// WebAuthFlow::Delegate implementation.

virtual void OnAuthFlowFailure(WebAuthFlow::Failure failure) OVERRIDE;