Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chrome/browser/extensions/api/history/history_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/history/history_api.cc
diff --git a/chrome/browser/extensions/api/history/history_api.cc b/chrome/browser/extensions/api/history/history_api.cc
index 51670d2b8d93f2eac362d469ae6fee29b1547a68..bf0608865f676d5df3dc43837696378e3722452e 100644
--- a/chrome/browser/extensions/api/history/history_api.cc
+++ b/chrome/browser/extensions/api/history/history_api.cc
@@ -270,7 +270,7 @@ HistoryFunctionWithCallback::HistoryFunctionWithCallback() {
HistoryFunctionWithCallback::~HistoryFunctionWithCallback() {
}
-bool HistoryFunctionWithCallback::RunImpl() {
+bool HistoryFunctionWithCallback::RunAsync() {
AddRef(); // Balanced in SendAysncRepose() and below.
bool retval = RunAsyncImpl();
if (false == retval)
@@ -286,7 +286,7 @@ void HistoryFunctionWithCallback::SendAsyncResponse() {
void HistoryFunctionWithCallback::SendResponseToCallback() {
SendResponse(true);
- Release(); // Balanced in RunImpl().
+ Release(); // Balanced in RunAsync().
}
bool HistoryGetVisitsFunction::RunAsyncImpl() {
@@ -370,7 +370,7 @@ void HistorySearchFunction::SearchComplete(
SendAsyncResponse();
}
-bool HistoryAddUrlFunction::RunImpl() {
+bool HistoryAddUrlFunction::RunAsync() {
scoped_ptr<AddUrl::Params> params(AddUrl::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
@@ -386,7 +386,7 @@ bool HistoryAddUrlFunction::RunImpl() {
return true;
}
-bool HistoryDeleteUrlFunction::RunImpl() {
+bool HistoryDeleteUrlFunction::RunAsync() {
scoped_ptr<DeleteUrl::Params> params(DeleteUrl::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
« no previous file with comments | « chrome/browser/extensions/api/history/history_api.h ('k') | chrome/browser/extensions/api/identity/identity_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698