chrome/browser/extensions/api/app_window/app_window_api.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/app_window/app_window_api.h

diff --git a/chrome/browser/extensions/api/app_window/app_window_api.h b/chrome/browser/extensions/api/app_window/app_window_api.h

index de73bac525a76ae61f003e07a615e8e63723bcee..8f976bfddd8590ef40e326cd89a5dad88a491944 100644

--- a/chrome/browser/extensions/api/app_window/app_window_api.h

+++ b/chrome/browser/extensions/api/app_window/app_window_api.h

@@ -16,7 +16,7 @@ struct CreateWindowOptions;

}

-class AppWindowCreateFunction : public UIThreadExtensionFunction {

+class AppWindowCreateFunction : public AsyncExtensionFunction {

public:

AppWindowCreateFunction();

DECLARE_EXTENSION_FUNCTION("app.window.create", APP_WINDOW_CREATE)

@@ -25,7 +25,7 @@ class AppWindowCreateFunction : public UIThreadExtensionFunction {

protected:

virtual ~AppWindowCreateFunction() {}

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

private:

bool GetBoundsSpec(