chrome/browser/extensions/api/app_window/app_window_api.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/app_window/app_window_api.cc

diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc

index 14af30ae32ffdbc080ed7255db0da3822a148bbf..4f2b68eaf5672670e0a9279fb614087e130a07c2 100644

--- a/chrome/browser/extensions/api/app_window/app_window_api.cc

+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc

@@ -139,7 +139,7 @@ void AppWindowCreateFunction::SendDelayedResponse() {

SendResponse(true);

}

-bool AppWindowCreateFunction::RunImpl() {

+bool AppWindowCreateFunction::RunAsync() {

// Don't create app window if the system is shutting down.

if (extensions::ExtensionsBrowserClient::Get()->IsShuttingDown())

return false;