chrome/browser/chromeos/extensions/file_system_provider/provider_function.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_system_provider/provider_function.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc ('k') | chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_system_provider/provider_function.h

diff --git a/chrome/browser/chromeos/extensions/file_system_provider/provider_function.h b/chrome/browser/chromeos/extensions/file_system_provider/provider_function.h

index 10e8789d00bfb34cc6dc3d335477a553a5db8b1e..ed689c2cf71d2c4a00a5a9f0e13690151f03b51f 100644

--- a/chrome/browser/chromeos/extensions/file_system_provider/provider_function.h

+++ b/chrome/browser/chromeos/extensions/file_system_provider/provider_function.h

@@ -68,10 +68,15 @@ class FileSystemProviderInternalFunction : public ChromeSyncExtensionFunction {

scoped_ptr<chromeos::file_system_provider::RequestValue> value,

bool has_next);

- // ChromeSyncExtensionFunction overrides.

- virtual bool RunImpl() OVERRIDE;

+ // Subclasses implement this for their functionality.

+ // Called after Parse() is successful, such that |request_id_| and

+ // |request_manager_| have been fully initialized.

+ virtual bool RunWhenValid() = 0;

private:

+ // ChromeSyncExtensionFunction overrides.

+ virtual bool RunSync() OVERRIDE;

// Parses the request in order to extract the request manager. If fails, then

// sets a response and returns false.

bool Parse();