chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h ('k') | chrome/browser/chromeos/extensions/file_system_provider/provider_function.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

diff --git a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

index 8e378db97f95733671b9818194b3262df62e8774..d37f23c9b5b968c918040eb9ee7409ea0f22fe76 100644

--- a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

+++ b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

@@ -85,7 +85,7 @@ bool FileSystemProviderUnmountFunction::RunSync() {

return true;

}

-bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunSync() {

+bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunWhenValid() {

using api::file_system_provider_internal::UnmountRequestedSuccess::Params;

scoped_ptr<Params> params(Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params);

@@ -95,7 +95,7 @@ bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunSync() {

return true;

}

-bool FileSystemProviderInternalUnmountRequestedErrorFunction::RunSync() {

+bool FileSystemProviderInternalUnmountRequestedErrorFunction::RunWhenValid() {

using api::file_system_provider_internal::UnmountRequestedError::Params;

const scoped_ptr<Params> params(Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params);

@@ -104,7 +104,8 @@ bool FileSystemProviderInternalUnmountRequestedErrorFunction::RunSync() {

return true;

}

-bool FileSystemProviderInternalGetMetadataRequestedSuccessFunction::RunSync() {

+bool

+FileSystemProviderInternalGetMetadataRequestedSuccessFunction::RunWhenValid() {

using api::file_system_provider_internal::GetMetadataRequestedSuccess::Params;

scoped_ptr<Params> params(Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params);

@@ -114,7 +115,8 @@ bool FileSystemProviderInternalGetMetadataRequestedSuccessFunction::RunSync() {

return true;

}

-bool FileSystemProviderInternalGetMetadataRequestedErrorFunction::RunSync() {

+bool

+FileSystemProviderInternalGetMetadataRequestedErrorFunction::RunWhenValid() {

using api::file_system_provider_internal::GetMetadataRequestedError::Params;

const scoped_ptr<Params> params(Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params);