chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/push_messaging/push_messaging_api.cc ('k') | chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc » ('j') | extensions/browser/api/storage/storage_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h

diff --git a/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h b/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h

index c88cb01c6ede5e3ab139f46d2158d027bc50e6ff..bedc0fb8be298e813ac77500e872dcaf877b2678 100644

--- a/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h

+++ b/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h

@@ -24,7 +24,7 @@ class ReadingListPrivateAddEntryFunction : public ChromeAsyncExtensionFunction {

virtual ~ReadingListPrivateAddEntryFunction() {}

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

};

class ReadingListPrivateRemoveEntryFunction