chrome/browser/extensions/api/push_messaging/push_messaging_api.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc b/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

index 5ed1365b1c7f1e842d1aa75044941d3d775be6ef..5180d8581a450f66cba56c7b9dfc264f1304fdde 100644

--- a/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

@@ -90,7 +90,7 @@ PushMessagingGetChannelIdFunction::PushMessagingGetChannelIdFunction()

PushMessagingGetChannelIdFunction::~PushMessagingGetChannelIdFunction() {}

-bool PushMessagingGetChannelIdFunction::RunImpl() {

+bool PushMessagingGetChannelIdFunction::RunAsync() {

// Fetch the function arguments.

scoped_ptr<glue::GetChannelId::Params> params(

glue::GetChannelId::Params::Create(*args_));

@@ -222,7 +222,7 @@ void PushMessagingGetChannelIdFunction::ReportResult(

timeout);

}

- // Balanced in RunImpl.

+ // Balanced in RunAsync.

Release();

}