Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2573303002: DevTools: don't report violations in the error/warning counter. (Closed)

Created:
4 years ago by pfeldman
Modified:
4 years ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: don't report violations in the error/warning counter. BUG=673984 Committed: https://crrev.com/08525f40da9cafaeaa6e4b89cd49dbe34d02a5b5 Cr-Commit-Position: refs/heads/master@{#438910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
pfeldman
4 years ago (2016-12-14 23:29:01 UTC) #2
kozy
lgtm
4 years ago (2016-12-14 23:34:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573303002/1
4 years ago (2016-12-15 00:43:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/350338)
4 years ago (2016-12-15 00:50:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573303002/1
4 years ago (2016-12-15 02:24:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/315273)
4 years ago (2016-12-15 02:32:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573303002/1
4 years ago (2016-12-15 18:55:50 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 20:25:03 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-15 20:28:58 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08525f40da9cafaeaa6e4b89cd49dbe34d02a5b5
Cr-Commit-Position: refs/heads/master@{#438910}

Powered by Google App Engine
This is Rietveld 408576698