Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: components/cronet/android/BUILD.gn

Issue 2573253002: [Cronet] Enforce building Cronet with use_platform_icu_alternatives == true (Closed)
Patch Set: Address comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index 725024e297a43e8c5c7280cbae71ad33bd4c765f..eb787c88cef589d3fc0c9815c7a8dab82aede17a 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -1109,9 +1109,11 @@ if (target_cpu == "arm" && arm_version == 7 && !arm_use_neon) {
}
group("cronet_package") {
+ # Enforce building with ICU alternatives, crbug.com/611621.
# Enforce that arm_use_neon==false when building for ARMv7 by
# not including any deps in cronet_package target otherwise.
- if (!(target_cpu == "arm" && arm_version == 7) || !arm_use_neon) {
+ if (use_platform_icu_alternatives &&
+ (!(target_cpu == "arm" && arm_version == 7) || !arm_use_neon)) {
deps = [
":cronet_package_copy",
":cronet_package_copy_native_lib",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698