Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: components/cronet/android/BUILD.gn

Issue 2573253002: [Cronet] Enforce building Cronet with use_platform_icu_alternatives == true (Closed)
Patch Set: Address comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 import("//build/util/process_version.gni") 8 import("//build/util/process_version.gni")
9 import("//build/util/version.gni") 9 import("//build/util/version.gni")
10 import("//testing/test.gni") 10 import("//testing/test.gni")
(...skipping 1091 matching lines...) Expand 10 before | Expand all | Expand 10 after
1102 "--stamp", 1102 "--stamp",
1103 rebase_path(outputs[0], root_build_dir), 1103 rebase_path(outputs[0], root_build_dir),
1104 ] 1104 ]
1105 deps = [ 1105 deps = [
1106 "//base:base", 1106 "//base:base",
1107 ] 1107 ]
1108 } 1108 }
1109 } 1109 }
1110 1110
1111 group("cronet_package") { 1111 group("cronet_package") {
1112 # Enforce building with ICU alternatives, crbug.com/611621.
1112 # Enforce that arm_use_neon==false when building for ARMv7 by 1113 # Enforce that arm_use_neon==false when building for ARMv7 by
1113 # not including any deps in cronet_package target otherwise. 1114 # not including any deps in cronet_package target otherwise.
1114 if (!(target_cpu == "arm" && arm_version == 7) || !arm_use_neon) { 1115 if (use_platform_icu_alternatives &&
1116 (!(target_cpu == "arm" && arm_version == 7) || !arm_use_neon)) {
1115 deps = [ 1117 deps = [
1116 ":cronet_package_copy", 1118 ":cronet_package_copy",
1117 ":cronet_package_copy_native_lib", 1119 ":cronet_package_copy_native_lib",
1118 ":cronet_package_copy_native_lib_unstripped", 1120 ":cronet_package_copy_native_lib_unstripped",
1119 ":generate_javadoc", 1121 ":generate_javadoc",
1120 ":generate_licenses", 1122 ":generate_licenses",
1121 ":jar_cronet_api_source", 1123 ":jar_cronet_api_source",
1122 ":jar_cronet_impl_common_java_source", 1124 ":jar_cronet_impl_common_java_source",
1123 ":jar_cronet_impl_native_java_source", 1125 ":jar_cronet_impl_native_java_source",
1124 ":jar_cronet_impl_platform_java_source", 1126 ":jar_cronet_impl_platform_java_source",
1125 ":jar_cronet_sample_source", 1127 ":jar_cronet_sample_source",
1126 ":repackage_extracted_jars", 1128 ":repackage_extracted_jars",
1127 ] 1129 ]
1128 if (current_cpu == "arm" && arm_version == 7) { 1130 if (current_cpu == "arm" && arm_version == 7) {
1129 deps += [ ":enforce_no_neon" ] 1131 deps += [ ":enforce_no_neon" ]
1130 } 1132 }
1131 } 1133 }
1132 } 1134 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698