[wasm] disable serialization for asm-wasm

[wasm] disable serialization for asm-wasm

Determine if the scope of the function to be serialized includes asm-
wasm, and if so, bypass serialization, since we do not support it in
that scenario.

In this change, we do so regardless of whether the asm-wasm path was
successful. This is so we keep the design simple, since the guidance
to developers, moving forward, is to use wasm.

BUG=643595
Committed: https://crrev.com/77b50a8e126186488992b14b0760ed043a9d7631
Cr-Commit-Position: refs/heads/master@{#41704}

[Mircea Trofin, 2016-12-14 19:40:25]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 19:40:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 19:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 19:53:29]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Mircea Trofin, 2016-12-14 23:34:03]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 23:34:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 00:02:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:02:35]

Dry run: This issue passed the CQ dry run.

[Mircea Trofin, 2016-12-15 00:06:55]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 00:07:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2016-12-15 00:14:57]

Description was changed from

==========
[wasm] disable serialization for asm-wasm

BUG=643595
==========

to

==========
[wasm] disable serialization for asm-wasm

Determine if the scope of the function to be serialized includes asm-
wasm, and if so, bypass serialization, since we do not support it in 
that scenario.

In this change, we do so regardless of whether the asm-wasm path was 
successful. This is so we keep the design simple, since the guidance
to developers, moving forward, is to use wasm.

BUG=643595
==========

[Mircea Trofin, 2016-12-15 00:14:58]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org, yangguo@google.com

[Mircea Trofin, 2016-12-15 00:19:12]

PTAL.

Please validate my assumptions that:
- scopes are indeed forming a tree. I inferred from comments
that Scope refers to a lexical scope, and the inner/sibling
links are lexical relations. Is that correct?

- the implication that if there is no asm-wasm scope, it 
also means that there is no asm-wasm module in the object
graph to be serialized.

Thanks!

[commit-bot: I haz the power, 2016-12-15 00:32:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:32:08]

Dry run: This issue passed the CQ dry run.

[bradn, 2016-12-15 05:04:50]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-12-15 05:04:50]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-12-15 05:04:51]

lgtm

[commit-bot: I haz the power, 2016-12-15 05:05:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 05:06:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481778290400500,
"parent_rev": "583681c4ee8512fd18a780bf3c4a888e66bb81a9", "commit_rev":
"7a3e1954763b65200a457047e59e0a23c1b6f317"}

[commit-bot: I haz the power, 2016-12-15 05:06:44]

Description was changed from

==========
[wasm] disable serialization for asm-wasm

Determine if the scope of the function to be serialized includes asm-
wasm, and if so, bypass serialization, since we do not support it in 
that scenario.

In this change, we do so regardless of whether the asm-wasm path was 
successful. This is so we keep the design simple, since the guidance
to developers, moving forward, is to use wasm.

BUG=643595
==========

to

==========
[wasm] disable serialization for asm-wasm

Determine if the scope of the function to be serialized includes asm-
wasm, and if so, bypass serialization, since we do not support it in 
that scenario.

In this change, we do so regardless of whether the asm-wasm path was 
successful. This is so we keep the design simple, since the guidance
to developers, moving forward, is to use wasm.

BUG=643595

Review-Url: https://codereview.chromium.org/2573193002
==========

[commit-bot: I haz the power, 2016-12-15 05:06:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 05:07:00]

Description was changed from

==========
[wasm] disable serialization for asm-wasm

Determine if the scope of the function to be serialized includes asm-
wasm, and if so, bypass serialization, since we do not support it in 
that scenario.

In this change, we do so regardless of whether the asm-wasm path was 
successful. This is so we keep the design simple, since the guidance
to developers, moving forward, is to use wasm.

BUG=643595

Review-Url: https://codereview.chromium.org/2573193002
==========

to

==========
[wasm] disable serialization for asm-wasm

Determine if the scope of the function to be serialized includes asm-
wasm, and if so, bypass serialization, since we do not support it in
that scenario.

In this change, we do so regardless of whether the asm-wasm path was
successful. This is so we keep the design simple, since the guidance
to developers, moving forward, is to use wasm.

BUG=643595

Committed: https://crrev.com/77b50a8e126186488992b14b0760ed043a9d7631
Cr-Commit-Position: refs/heads/master@{#41704}
==========

[commit-bot: I haz the power, 2016-12-15 05:07:01]

Patchset 3 (id:??) landed as
https://crrev.com/77b50a8e126186488992b14b0760ed043a9d7631
Cr-Commit-Position: refs/heads/master@{#41704}

[Yang, 2016-12-15 05:41:08]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-12-15 05:41:09]

lgtm

https://codereview.chromium.org/2573193002/diff/40001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2573193002/diff/40001/src/compiler.cc#newcode...
src/compiler.cc:1352: // We assume scopes form a tree, so no need to check for
cycles
I think this can be done a lot easier. We have all shared function infos that
have been compiled in GetSharedFunctionInfoForScript listed in
Script::shared_function_infos. You can iterate through it using
WeakFixedArray::Iterator. There you can figure out whether there is an asm
module involved.